Repository navigation
feat(web): put panel tab close buttons after the title - #18199
alexandre-vl wants to merge 1 commit into
Conversation
Right-panel tabs and the terminal list swapped a tab's icon for its close button on hover, so close sat left of the title. The icon now stays put and the close button follows the title. Inactive tabs float it over the end of the title on hover or keyboard focus, with a short fade, so hovering never changes a width. The active tab and the active terminal row keep it visible in its own space. A 64px min width keeps short titles, such as a terminal running vi, clickable, and touch screens always show the button. Viewers without terminal control get neither.
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a localized UI adjustment that repositions and refines visibility of existing panel and terminal close controls while preserving their callbacks, permissions, and close workflows. It introduces no schema, configuration, infrastructure, security, billing, or static-analysis changes. You can add or adjust custom eligibility rules. Learn more. |
|
Note This comment is posted by Julius' dot Closing for now: the approved scope keeps close hover/focus-revealed, but this PR makes it permanently visible on active tabs and terminal rows. Please keep that behavior within the approved scope or get approval for the change under the contribution guide. The screenshots show the layout, but the changed hover, keyboard-focus and touch interactions also need a short recording. Address those points and request reconsideration. |
|
Addressed both points in #18206: close is now hover/focus-revealed on every tab and terminal row, active ones included, and the PR has recordings of the hover, keyboard and touch interactions. |
Problem
Hovering a right-panel tab or a terminal-list row swaps its icon for the close button, so close sits left of the title.
Change
viis labelled "vi", 9px wide.ThreadRelationshipsControl.Scope and approval
Approved in #17986 (converted from #11877): #17986 (comment), "Target the VS Code-style row:
[icon] [title] [× on hover]", optionally in the terminal list too.Two choices go beyond that row: the active tab keeps its × visible, and the 64px min width. Happy to drop either.
Written from scratch on current main. Supersedes #12062, which was closed in the PR cleanup.
Verification
Dev build, headless Chrome:
terminal:operatesees no × and no fade.vp fmt,vp lint, web typecheck, and the RightPanelTabs / ThreadTerminalDrawer tests (40) pass.Model: claude-opus-5-5 · Harness: Claude Code