Repository navigation
fix(desktop): compile annotation CSS in the preload bundler - #17850
t3-code[bot] wants to merge 2 commits into
Conversation
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — The PR moves annotation CSS generation into the production Electron preload bundler and adds watch-aware integration coverage, while preserving the existing runtime injection path. Human review is warranted because the new bundler and test files suppress a static-analysis diagnostic. Notes:
You can add or adjust custom eligibility rules. Learn more. |
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
Dismissing prior approval to re-evaluate c50ab39
|
The two |
Co-authored-by: Mike Olson <1510193+mwolson@users.noreply.github.com>
Co-authored-by: Mike Olson <1510193+mwolson@users.noreply.github.com>
c50ab39 to
ecd60b4
Compare
Desktop annotation styles are compiled into a tracked TypeScript file before bundling. That can leave a dirty tree after a build, and the one-shot generation step does not refresh CSS during watch rebuilds.
Compile the stylesheet through a Vite+ Pack plugin instead. The preview preload imports a typed virtual module whose CSS remains embedded in the sandboxed preload bundle. Watch dependencies include the annotation CSS, preload class candidates, and Tailwind theme/preflight inputs; each load uses a fresh compiler so removed utilities disappear.
Remove the old generator and tracked output. Ignore the exact legacy output path and remove any leftover file at build start, so builds from older checkouts cannot supply stale CSS or leave an untracked generated file behind. Normal Git protections for local modifications still apply when switching branches; this does not force checkout or reset user changes.
#17838 has merged. This follow-up is rebased on main and replaces the refreshed tracked stylesheet with build-time compilation.
verification
vp pack --filter preview-pick-preloadusing Vite+ 1.0.0 and Tailwind 4.3.3.git diff --checkpass.requested by @mwolson. co-author credit included.
model: gpt-6.1-sol. harness: hermes agent.