fix(pi): preserve shell command exit codes

[StiensWout]

Problem

Pi 1.1 shell results report exit codes in structuredContent.exit_code, while older versions use details.exitCode. PowerShell results also fell through to generic tool output.

Change

Handle bash and PowerShell as shell commands, prefer the current exit code, and retain the legacy fallback.

Scope and approval

Small adapter bug fix: current Pi shell exit codes and PowerShell results were normalized incorrectly. No new capability or setting.

Verification

Validation: 79 adapter tests, Pi typecheck and scoped lint/format checks passed.

_{Prepared for Wout by gpt-6.1-sol in Codex.}

[macroscopeapp]

Approvability

Verdict: Approved at e7f4f40

Macroscope's review found this PR approvable — This is a focused Pi adapter bug fix that normalizes current and legacy shell exit-code formats and correctly presents PowerShell executions. It includes targeted coverage for both shell tools and does not change defaults, schemas, deployment, or static-analysis configuration.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Path: .coderabbit.config.ts
• Review profile: CHILL
• Plan: Advanced
• Run ID: 3ea2b935-4a73-4293-bf0b-9695110bd178

---

---

📥 Commits

Reviewing files that changed from the base of the PR and between 8c777fb and e7f4f40.

---

---

📒 Files selected for processing (2)

• packages/provider-pi/src/server/adapter.test.ts
• packages/provider-pi/src/server/adapter.ts

---

---

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

---

---

---

📝 Walkthrough

📝 Walkthrough

Walkthrough

The Pi adapter now emits command execution items for Bash and PowerShell calls. It reads the exit code from structured content first, then falls back to the legacy details field. Tests cover both formats and successful and failing results.

Changes

Pi command execution results

Layer / File(s)	Summary
Command item results packages/provider-pi/src/server/adapter.ts, packages/provider-pi/src/server/adapter.test.ts	Bash and PowerShell calls emit command execution items. The adapter reads structuredContent.exit_code first and falls back to details.exitCode. Tests cover both exit-code formats and verify item status, tool name, input, output, and reported exit code.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: juliusmarminge

---

---

Merge Risk: ⚪ Minimal · up to e7f4f

PowerShell command results now keep their exit codes, as Bash results already did, and both the structured and legacy result formats are supported. The tests cover both tools and both formats, and no merge-blocking risk was found.

Architecture Summary

Architecture risk: 🔵 Low · up to e7f4f

The change affects 1 system.

Changed systems: packages/provider-pi

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

• observed — packages/provider-pi (library) was modified; 2 changed files map to changed impact.

Before / after behavior

• observed — Modified behavior in packages/provider-pi/src/server/adapter.test.ts: Adds cases for bash and powershell command results using structured exit_code or legacy details.exitCode. The test checks running-item input and verifies that the final command item preserves the tool name, input, and output, reports the selected exit code, and is completed only for exit code 0.
• observed — Modified behavior in packages/provider-pi/src/server/adapter.ts: PowerShell calls now follow Bash into the command_execution item path. Both read the exit code from structuredContent.exit_code first, falling back to details.exitCode; previously, only Bash used this path and read from details.exitCode.

---

---

Pre-merge checks | 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Title check		The title clearly and concisely describes the main fix: preserving shell command exit codes in the Pi adapter.
Description check		The description includes the required Problem, Change, Scope and approval, and Verification sections. It explains the bug, the implementation, the focused scope, and the reported test and validation r…

---

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

---

---

---

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

_{Comment @coderabbitai help to get the list of available commands.}