Skip to content

fix(web): omit underlines on markdown image links #17728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Yash-Singh1 merged 4 commits into from
Oct 10, 2026
Merged

fix(web): omit underlines on markdown image links #17728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c5c01ad
fix(web): omit underlines on markdown image links
Saikrishna1876 Oct 10, 2026
241fed3
Merge branch 'main' into fix/coderabbit-button-underline
Saikrishna1876 Oct 10, 2026
a129640
Merge branch 'main' into fix/coderabbit-button-underline
Saikrishna1876 Oct 10, 2026
f8335c3
Merge branch 'main' into fix/coderabbit-button-underline
Saikrishna1876 Oct 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion apps/web/src/components/ChatMarkdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2943,6 +2943,7 @@ const CHAT_MARKDOWN_COMPONENTS = {
: null;
if (!fileLinkMeta) {
const faviconHost = resolveExternalWebLinkHost(href);
const hasText = hastHasText(node);
const pullRequestAutolink = String(
(props as Record<string, unknown>)["data-pull-request-autolink"] ?? "",
);
Expand Down Expand Up @@ -2974,6 +2975,7 @@ const CHAT_MARKDOWN_COMPONENTS = {
{...props}
className={cn(props.className, pullRequestAutolink === "commit" && "font-mono")}
data-markdown-copy={pullRequestCopy}
data-markdown-image-link={!hasText || undefined}
href={href}
target={isSameDocumentLink ? undefined : "_blank"}
rel={isSameDocumentLink ? undefined : "noopener noreferrer"}
Expand Down Expand Up @@ -3093,7 +3095,7 @@ const CHAT_MARKDOWN_COMPONENTS = {
});
}}
>
{faviconHost && hastHasText(node) && !isPullRequestAutolink ? (
{faviconHost && hasText && !isPullRequestAutolink ? (
<MarkdownExternalLinkContent host={faviconHost} plainText={plainHastText(node)}>
{linkChildren}
</MarkdownExternalLinkContent>
Expand Down
4 changes: 2 additions & 2 deletions apps/web/src/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1895,8 +1895,8 @@ code {
color: var(--info-foreground);
}

.chat-markdown a:not(.chat-markdown-file-link):hover,
.chat-markdown a:not(.chat-markdown-file-link):focus-visible {
.chat-markdown a:not(.chat-markdown-file-link, [data-markdown-image-link]):hover,
.chat-markdown a:not(.chat-markdown-file-link, [data-markdown-image-link]):focus-visible {
background-image: radial-gradient(circle, currentcolor 0.75px, transparent 1px);
background-position: left bottom;
background-repeat: repeat-x;
Expand Down
Loading