Skip to content

test(usage): usage service tests keep their state directory until cache writes land #17636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 2 commits into from
Oct 10, 2026
Merged

test(usage): usage service tests keep their state directory until cache writes land #17636

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef17a32
test(usage): usage service tests keep their state directory until cac…
tris203 Oct 9, 2026
5d621e1
test(usage): drop the v4 upgrade test's now-redundant cache write wait
tris203 Oct 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions apps/server/src/usage/UsageService.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,9 @@ const layerService = (input: {
Layer.provideMerge(ProviderHostLive.layer),
Layer.provideMerge(Layer.mock(BackgroundPolicy.BackgroundPolicy)({})),
Layer.provideMerge(Layer.mock(ServerSecretStore.ServerSecretStore)({})),
Layer.provideMerge(ServerConfig.layerTest(process.cwd(), { prefix: input.prefix })),
Layer.provideMerge(
ServerConfig.layerTest(process.cwd(), NodePath.join(input.home, input.prefix)),
),
Layer.provideMerge(NodeServices.layer),
Layer.provideMerge(Layer.succeed(HostProcessPlatform, input.platform ?? "linux")),
Layer.provideMerge(ServerSettings.layerTest(input.settings)),
Expand Down Expand Up @@ -1175,8 +1177,7 @@ describe("UsageService", () => {
return text;
});

const restarted = yield* UsageService.make;
const summary = yield* restarted.readSummary(WINDOW);
const summary = yield* (yield* UsageService.make).readSummary(WINDOW);
// The live rollout re-parses at the ultrafast rate (10 x 6); the
// deleted one keeps its saved v4 usage at the standard rate (20 x 1).
assert.strictEqual(totalOutputTokens(summary), 30);
Expand All @@ -1189,9 +1190,6 @@ describe("UsageService", () => {
yield* Effect.promise(() => NodeFSP.readFile(legacyPath, "utf8")),
legacy,
);
// The migrated cache is written in the background; let it land before
// the layer removes the state directory under it.
yield* restarted.awaitPersisted;
}).pipe(
Effect.provide(
layerService({
Expand Down
Loading