Repository navigation
fix(web): usage limit recovery errors no longer crush the composer banner - #17457
Open
patryksztuczka wants to merge 1 commit into
Open
patryksztuczka wants to merge 1 commit into
patryksztuczka wants to merge 1 commit into
Conversation
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a focused one-file UI fix that preserves recovery actions and error reporting while preventing failure text from collapsing the composer banner. It uses existing toast infrastructure and does not alter server behavior, contracts, product defaults, or static-analysis configuration. You can add or adjust custom eligibility rules. Learn more. |
…nner Show Resume/Snooze failures as an error toast instead of inline text in the banner's auto-sized actions column, which widened to fit the message and squeezed the title down to a few characters. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
patryksztuczka
force-pushed
the
t3/composer-error-layout
branch
from
October 9, 2026 09:20
4c6be82 to
c47f8b6
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When Resume at reset or Snooze until reset fails on the usage-limit composer notice, the error text appears inside the notice's actions column. That column sizes to its content, so a long message such as "The provider limit changed before recovery could be configured." widens it until the title shrinks to a few characters ("U r"). The reset time disappears behind the details popover, and the notice grows a second line.
Expected: the notice keeps its one-row layout, the title and reset time stay readable, and the failure is still reported.
To reproduce: a thread stops at a provider usage limit and has a known reset time. Click Resume at reset or Snooze until reset, and have the metadata update fail, for example because the limit changed on the server or the remote environment is disconnected.
Change
UsageLimitRecoveryBanner.tsxreports these failures with an error toast instead of inline text. The toast title is "Could not change auto-resume" or "Could not snooze thread", and the server's message is the description. Other composer notice actions already report failures this way, for example the feedback notice's "Could not copy thread ID". The two buttons are now direct children of the actions slot, without a wrapperdiv, so a narrow composer uses the stack's existing wrap layout, the same as the goal notice.Mobile's
UsageLimitRecoveryCardis a full-width card with the error below the buttons, so it doesn't have this problem and is unchanged.Scope and approval
This is a small, focused fix for an obvious layout bug, so it uses the no-prior-issue exception. It is one web file and one problem: failure text overflowed an auto-sized column. It adds no workflow or setting and changes no server behavior or contracts. The before screenshots show the defect. The failure is still reported, through the toast mechanism that other notice actions already use. It is not shown inline anymore, which is what caused the overflow.
Verification
ComposerBannerStackandusageLimitRecoveryBannerItemin a temporary harness page in the web app's dev server, with anonChangethat fails on purpose. The before version shows the title collapsed and the error filling the row. The after version keeps one row and shows the toast.tsc --noEmitforapps/webandvp linton the changed file both pass.Full app (1440×900, 2x)
Provider limit changed (Resume)
Disconnected environment (Snooze)
Narrow composer (~380px)
Failure without a message
Made with Claude Opus 5.5 in Claude Code, running in T3 Code.
🤖 Generated with Claude Code