perf(web): switching project keeps Diagnostics and Providers mounted

[flamboh]

Note

🤖 Claude Opus 5.5 on behalf of Oliver

Problem

The Settings layout keys its content on the whole scope search, so changing the project scope remounts the page. Diagnostics and Providers belong to an environment and don't change with project. Every project switch rebuilt them from scratch.

Fix

On Diagnostics and Providers, the layout now keys its content on the resolved environment (useSettingsScope().environment?.environmentId) plus the restore signal. Other pages keep the full scope key. Switching project keeps those two pages mounted. They still reset when the environment changes, including an implicit change with no machine in the URL, and when the environment disconnects.

Since those pages no longer remount on a project switch, the scope menus now close when you pick an item (closeOnClick). Other pages already closed them by remounting.

This PR is independent of #17120 and based on main.

Switch project scope	Before → after (CPU task time)
Diagnostics, production	455 → 210 ms
Diagnostics, dev	286 → 157 ms
Providers, production	210 → 100 ms
Providers, dev	167 → 64 ms

Each median comes from 6 interleaved before/after runs in headless Chromium, on an isolated dev server and on the production build. Production runs use 4× CPU throttling. These were measured while this branch was still stacked on #17120, so both sides include #17120's shared Diagnostics tooltip, and the after side used an earlier environment key. Either key leaves the page mounted on a project switch, so the comparison holds, but I have not re-measured this rebuilt branch.

Before and after

Diagnostics, switching project scope three times. Before rebuilds the page on every switch; after keeps it mounted. In this take the three switches took 540 / 483 / 397 → 294 / 166 / 205 ms.

https://gh-file-drop-api-prod-galwoqjslzlnws6s.oliver-boorstein.workers.dev/f/9f4be9bdbd01efd1/pr17122-before-after.mp4

Production build, headless Chromium, CPU throttled 4× during the interaction. Before is main. After is the earlier stacked version of this branch (a86c58b9ca), which behaves the same on a project switch. These are single takes, so treat the timings as illustrative; the table above has the medians.

Scope and approval

I found no existing issue or discussion about Settings performance, so no maintainer has approved this yet. It is a focused performance improvement with no intended behavior change, which CONTRIBUTING lists among the changes most likely to be accepted. It is part of a Settings performance series: #17119, #17120, #17121, #17122 and #17123.

Validation

• Web typecheck passes and targeted lint is clean. 207 tests pass across 17 settings test files.
• settingsScopeRetention.test.tsx checks that Diagnostics and Providers keep their state across a project switch. It also checks that they reset on an environment switch, an implicit environment change and a disconnect, and that Keybindings still resets on a project switch. Against main's layout, 5 of its 8 cases fail. Against the earlier machine key, the implicit-change and disconnect cases fail.
• Earlier headless checks on the stacked version covered all 18 scope switches per page. They have not been re-run on this rebuilt branch.
• Not exercised: a second live environment.

Implemented by GPT-6.1 Sol (Codex harness, delegated through T3 Code). Split, verified, opened and given regression tests by Claude Opus 5.5 (Claude Code). Rebuilt on main after review by Claude Opus 5.5 via Claude Code in T3 Code.

[macroscopeapp]

Approvability

Verdict: Approved at 2e74ff6

Macroscope's review found this PR approvable — This is a small, localized settings UI optimization: Diagnostics and Providers retain their state across project switches while still resetting for environment changes, with regression coverage for the relevant transitions. It introduces no schema, deployment, security, billing, default, or static-analysis changes.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Path: .coderabbit.config.ts
• Review profile: CHILL
• Plan: Advanced
• Run ID: 918b1d98-7fe0-47da-95cd-cfc6cbd3031a

---

📥 Commits

Reviewing files that changed from the base of the PR and between 9e40195 and 2e74ff6.

---

📒 Files selected for processing (3)

• apps/web/src/components/settings/SettingsScopeSentence.tsx
• apps/web/src/components/settings/settingsScopeRetention.test.tsx
• apps/web/src/routes/settings.tsx

---

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 1 remain after this review.

---

---

📝 Walkthrough

Walkthrough

Settings scope menu items now close when selected. Diagnostics and providers key their content by the selected environment ID. Tests check how outlet state responds to scope changes.

Changes

Settings scope behavior

Layer / File(s)	Summary
Close scope menus after selection apps/web/src/components/settings/SettingsScopeSentence.tsx	All-environments, individual-environment, all-projects, and individual-project radio items close their menus when clicked.
Key settings content by route scope apps/web/src/routes/settings.tsx, apps/web/src/components/settings/settingsScopeRetention.test.tsx	Diagnostics and providers use the selected environment ID as the content key. Other settings pages use serialized search state. Tests check state retention for project changes and resets for environment, implicit-environment, and disconnect changes.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: juliusmarminge

---

Merge Risk: ⚪ Minimal · up to 2e74f

The change keeps Diagnostics and Providers mounted when the project changes, and closes the scope menus after a selection. No concrete merge-blocking risk was identified.

Security Architecture Review

Security architecture risk: ⚪ Minimal · up to 2e74f

The retained state remains environment-owned. Environment changes still reset the affected pages, and privileged actions continue to carry an explicit environment identity and use permission checks. No material security risk introduced or worsened by this change was identified.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

• inferred — The changed lifetime reaches environment-sensitive diagnostics and provider-management actions, but inspected dispatch paths retain explicit environment targets. A project-only switch does not select a new command destination or grant additional authority; an environment switch changes outlet identity.

Trust Boundaries and Controls

• observed — Diagnostics process signaling checks maintenance permission before initiation, rejects re-entry, and after confirmation rechecks environment identity, permission and process start time. Environment RPC commands bind execution to the supplied environment and invoke authorization before guarded dispatch, including a destination authorization callback.

Resilience and Maintainability Implications

• observed — Started commands are not coupled to component-unmount cancellation by the unchanged command hook; runtime execution mounts and waits in its own scope. Failures settle into command results, queries are keyed by environment and input, and provider refreshes use environment-sensitive single-flight keys. The PR therefore does not remove an existing hook-level unmount cancellation control.

---

---

Pre-merge checks | 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Title check		The title clearly identifies the main change: keeping Diagnostics and Providers mounted when switching projects.
Description check		The description is mostly complete. It explains the problem, fix, scope rationale, performance results, validation, limitations, and implementation details. It includes a before-and-after recording, b…

---

---

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

---

---

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

_{Comment @coderabbitai help to get the list of available commands.}

Dismissing prior approval to re-evaluate 1a616c0