Skip to content

fix(web): align semantic branch naming hint - #16721

Closed
hung-ng wants to merge 1 commit into
pingdotgg:mainfrom
hung-ng:fix/semantic-branch-hint-alignment
Closed

hung-ng wants to merge 1 commit into
pingdotgg:mainfrom
hung-ng:fix/semantic-branch-hint-alignment

Conversation

@hung-ng

@hung-ng hung-ng commented Oct 7, 2026 •

Copy link
Copy Markdown

Problem

Selecting Semantic prefix showed its explanatory text in a separate block with different horizontal and vertical alignment from the other setting descriptions. The extra block also added more vertical weight than the surrounding settings.

Change

Keep the explanation inside the existing Worktree branch naming description. It uses the same left column and subdued text treatment as the other settings, with two examples so it stays on one line in the desktop layout.

Scope and approval

This is a small, focused presentation fix for an existing source control setting. It changes no branch-generation behavior, settings schema, or other clients, so it qualifies as an obvious bug fix under the contribution exception.

Verification

  • ./node_modules/.bin/vp fmt --check apps/web/src/components/settings/BranchNamingSettings.tsx
  • ./node_modules/.bin/vp lint --report-unused-disable-directives apps/web/src/components/settings/BranchNamingSettings.tsx
  • ./node_modules/.bin/vp run --filter @t3tools/web typecheck
  • Manual preview at 1280px with Semantic prefix selected: the helper aligns with the row copy and remains on one line.

UI changes

Before: the semantic helper was separated from the setting content and did not share its alignment.

Before: semantic branch naming helper alignment

After: the helper sits under the existing description, with subdued styling and one-line examples.

After: semantic branch naming helper alignment

Checklist

  • This PR is small and focused on one underlying problem.
  • The change preserves existing branch naming behavior.
  • Before and after screenshots are included for this UI change.

Model: gpt-6.1-sol. Harness: Codex through T3 Code.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Oct 7, 2026
@hung-ng
hung-ng marked this pull request as ready for review October 7, 2026 05:27
@coderabbitai

coderabbitai Bot commented Oct 7, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Path: .coderabbit.config.ts
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 38078cf5-d377-4e7e-b36b-549da83db8a9
📥 Commits

Reviewing files that changed from the base of the PR and between 365aa87 and 1c4fcaa.

📒 Files selected for processing (1)
  • apps/web/src/components/settings/BranchNamingSettings.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The branch-naming settings description now includes an explanation and examples for semantic mode. The separate semantic-mode paragraph was removed.

Changes

Branch naming settings

Layer / File(s) Summary
Update semantic-mode explanation
apps/web/src/components/settings/BranchNamingSettings.tsx
The mode description now conditionally explains semantic mode with feat/add-search and fix/login-timeout examples. The separate paragraph and its refactor/auth example were removed.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: t3dotgg

Merge Risk: ⚪ Minimal · up to 1c4fc

The change only updates how semantic branch naming is explained in settings. No merge-blocking risk is evident.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the change to the semantic branch-naming hint.
Description check ✅ Passed The description covers the problem, change, scope and approval rationale, verification, and before-and-after screenshots for the UI change.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Approvability ✅ Passed This pull request changes only the description markup in apps/web/src/components/settings/BranchNamingSettings.tsx. It moves the existing semantic-mode explanation into the setting description and a…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@juliusmarminge

Copy link
Copy Markdown
Member

Note

Grok responding on behalf of Julius.

Superseded by merged #16972, which already landed the same semantic branch naming hint alignment fix. Closing this PR; please reopen if it still has unique changes beyond that fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants