Skip to content

fix(web): round the trailing PR checks hover surface - #16548

Open
parzival1l wants to merge 5 commits into
pingdotgg:mainfrom
parzival1l:fix/thread-pr-checks-hover
Open

parzival1l wants to merge 5 commits into
pingdotgg:mainfrom
parzival1l:fix/thread-pr-checks-hover

Conversation

@parzival1l

@parzival1l parzival1l commented Oct 6, 2026 •

Copy link
Copy Markdown

Fix the square hover highlight on the trailing PR checks button with last:rounded-e-lg, while keeping inner segments square.

Before / after

Rendered at 200% panel zoom; cropped without resizing image pixels.

Before After
Square checks hover Rounded checks hover

Verification

  • Dev browser on macOS: trailing checks corners change from 0px to 10px; checks before Fix stay square. The popover works, and neighboring controls keep their rounded corners.
  • 181 focused PR logic/status tests pass. Targeted lint, web typecheck, and web build pass.
  • Electron and mobile remain untested.

Replaces #16543. This is a small, focused visual bug fix with no product behavior change.

Model: GPT-6.1 Sol. Harness: OpenCode through T3 Code.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Oct 6, 2026
@coderabbitai

coderabbitai Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration
  • Configuration used: Path: .coderabbit.config.ts
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 90381c2e-e1e8-4867-b378-05e338ca790e
📥 Commits

Reviewing files that changed from the base of the PR and between 930ed01 and 8790173.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Path: .coderabbit.config.ts
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 16c460bc-4f49-49bf-ae9c-61adf3375700
📥 Commits

Reviewing files that changed from the base of the PR and between 9503155 and 69f0ccb.

📒 Files selected for processing (1)
  • apps/web/src/components/chat/threadDetailsPanelStyles.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The shared split-check styling now rounds the end corner of the last control.

Changes

Split-check styling

Layer / File(s) Summary
Round the last split-check control
apps/web/src/components/chat/threadDetailsPanelStyles.ts
THREAD_DETAILS_PANEL_SPLIT_CHECKS_CLASS adds last:rounded-e-lg. Other controls retain the existing shared styling.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix · Severity of issue fixed: Low

Suggested reviewers: rakshithbhat03

Merge Risk: ⚪ Minimal · up to 815a6

The final split-check segment gains rounded end corners while preceding segments remain square. No material regression is established, so the change is ready for normal checks.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and concisely describes the trailing PR checks hover-surface fix.
Description check ✅ Passed The description explains the problem and change, provides before-and-after screenshots, reports focused verification and untested platforms, and states why the focused fix needs no prior approval.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@tinsever tinsever left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@HaseebUllahButt

Copy link
Copy Markdown

why can i comment

@juliusmarminge juliusmarminge added the macroscope-review Opt PRs made by unvouched contributors in for Macroscope review. Vouched contributors auto-reviews label Oct 11, 2026 — with ChatGPT Codex Connector
@macroscopeapp

macroscopeapp Bot commented Oct 11, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 8790173

Macroscope's review found this PR approvable — This is a focused one-line web UI fix that rounds only the trailing PR checks hover surface. It does not alter product defaults, application behavior, APIs, or static-analysis configuration.

You can add or adjust custom eligibility rules. Learn more.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

macroscope-review Opt PRs made by unvouched contributors in for Macroscope review. Vouched contributors auto-reviews size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants