Skip to content

fix(server): main's settings, keybindings and session tests compile again #16363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 1 commit into from
Oct 6, 2026
Merged

fix(server): main's settings, keybindings and session tests compile again #16363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/server/src/keybindings.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -620,7 +620,7 @@ it.layer(NodeServices.layer)("keybindings", (it) => {
const configState = yield* keybindings.loadConfigState;
assert.deepEqual(configState.issues, []);
assert.isTrue(configState.keybindings.some((entry) => entry.command === "terminal.toggle"));
}).pipe(Effect.provide(makeKeybindingsLayer())),
}).pipe(Effect.provide(layerKeybindings())),
);

it.effect("updates cached resolved config after upsert", () =>
Expand Down
2 changes: 1 addition & 1 deletion apps/server/src/orchestration-v2/ProviderSessionManager.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -930,7 +930,7 @@ it.effect("ProviderSessionManagerV2 records provider session and turn metrics",
});

yield* effect.pipe(
Effect.provide(makeTestLayer({ state, idleTimeoutMs: 60_000 })),
Effect.provide(layerTest({ state, idleTimeoutMs: 60_000 })),
// A private registry keeps other tests' provider metrics out of the assertions.
Effect.provideService(Metric.MetricRegistry, new Map()),
);
Expand Down
4 changes: 2 additions & 2 deletions apps/server/src/serverSettings.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ const layerServerSettings = () =>
),
);

/** Like `makeServerSettingsLayer`, but also exposes the secret store for assertions. */
/** Like `layerServerSettings`, but also exposes the secret store for assertions. */
const layerServerSettingsWithSecrets = () =>
ServerSettingsModule.layer.pipe(
Layer.provideMerge(ServerSecretStore.layer),
Expand Down Expand Up @@ -322,7 +322,7 @@ it.layer(NodeServices.layer)("server settings", (it) => {

const settings = yield* serverSettings.getSettings;
assert.equal(settings.responseStreamingMode, "turn");
}).pipe(Effect.provide(makeServerSettingsLayer())),
}).pipe(Effect.provide(layerServerSettings())),
);

it.effect("decodes nested settings patches", () =>
Expand Down
Loading