Skip to content

feat(web): see and stop pull request watches from the PR hover card - #16226

Closed
t3dotgg wants to merge 1 commit into
mainfrom
t3code/watched-pr-eye
Closed

t3dotgg wants to merge 1 commit into
mainfrom
t3code/watched-pr-eye

Conversation

@t3dotgg

@t3dotgg t3dotgg commented Oct 5, 2026

Copy link
Copy Markdown
Member

You could not tell which pull requests a thread was watching without opening the Linked pull requests panel. Stopping a watch took a trip to that panel's row menu.

Now the PR badge's hover card (sidebar rows and the composer footer) shows an eye on each watched, open pull request. Hover the eye and it crosses out. Click it to stop watching that pull request. The click uses the same watchPullRequest command as the panel's "Stop watching" item. The sidebar's thread hover card shows the same eye, but you cannot click it there because that card does not take clicks.

Watching After clicking the eye
Hover card with an eye on the watched PR Same card after stopping, eye gone

Verified against a local dev server: I started a watch from the panel, then the eye showed in the sidebar badge card. One click removed it from the card and the panel, cleared the "Waiting on monitor" banner, and left the selected thread unchanged.

Mobile already shows "Watching" in its linked PR list and is unchanged here.

Reviewed with sol-loop: 1 round with GPT-6.1 Sol on high.

Created with Claude Opus 5.5 in Claude Code.

🤖 Generated with Claude Code

…p control

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@github-actions github-actions Bot added the vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. label Oct 5, 2026
@juliusmarminge juliusmarminge added the macroscope-review Opt PRs made by unvouched contributors in for Macroscope review. Vouched contributors auto-reviews label Oct 5, 2026
@github-actions github-actions Bot added the size:M 30-99 changed lines (additions + deletions). label Oct 5, 2026
@macroscopeapp

macroscopeapp Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This adds an interactive PR-hover workflow that invokes the existing watch mutation to stop future monitoring, affecting persisted thread behavior across the sidebar and composer. The code is small and localized, but the new state-changing user path warrants human review.

You can add or adjust custom eligibility rules. Learn more.

@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 5.0 KiB 5.0 KiB 0 B (0.0%) 6.8 KiB ✅
Codex Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Codex Live turn WebSocket wire 1.2 KiB 1.2 KiB 0 B (0.0%) 2.0 KiB ✅
Codex Live turn WebSocket decoded 20.9 KiB 20.9 KiB 0 B (0.0%) 29.3 KiB ✅
Codex Live turn messages 2 2 0 (0.0%) 8 ✅
Claude Total thread wire 5.0 KiB 5.0 KiB 0 B (0.0%) 6.8 KiB ✅
Claude Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Claude Live turn WebSocket wire 1.2 KiB 1.2 KiB 0 B (0.0%) 2.0 KiB ✅
Claude Live turn WebSocket decoded 21.2 KiB 21.2 KiB 0 B (0.0%) 29.3 KiB ✅
Claude Live turn messages 2 2 0 (0.0%) 8 ✅

Baseline: 2afe87e · PR result: 97b94a8 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 108.5 KiB
  • Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@coderabbitai

coderabbitai Bot commented Oct 5, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: pingdotgg/t3code/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Team
  • Run ID: 69c067b1-4188-4f51-bca3-47b3bc1cb7aa
📥 Commits

Reviewing files that changed from the base of the PR and between 2afe87e and 97b94a8.

📒 Files selected for processing (4)
  • apps/web/src/components/BranchToolbarBranchSelector.tsx
  • apps/web/src/components/Sidebar.tsx
  • apps/web/src/components/ThreadStatusIndicators.tsx
  • docs/user/source-control.md

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 2 remain after this review.


📝 Walkthrough

Walkthrough

Pull-request badges now pass a thread reference to the pull-request mini-list. The mini-list shows watch status and lets users stop watching when a thread reference is available. The source-control guide describes the updated interaction.

Changes

Pull-request watch controls

Layer / File(s) Summary
Pass thread references
apps/web/src/components/BranchToolbarBranchSelector.tsx, apps/web/src/components/Sidebar.tsx, apps/web/src/components/ThreadStatusIndicators.tsx
The toolbar and sidebar pass their thread reference to the badge control. The badge control passes it to the pull-request mini-list.
Stop watching from the mini-list
apps/web/src/components/ThreadStatusIndicators.tsx, docs/user/source-control.md
The mini-list shows a stop-watching button for watched pull requests when a thread reference is available. Clicking it sends a command to set watching to false. Without a thread reference, the mini-list shows a static eye icon. The guide describes stopping a watch by clicking the eye on hover.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~15 minutes

Change: Feature

Sequence Diagram(s)

sequenceDiagram
  actor User
  participant ThreadPullRequestsMiniList
  participant ThreadWatchCommand
  User->>ThreadPullRequestsMiniList: Click stop-watching button
  ThreadPullRequestsMiniList->>ThreadWatchCommand: Set watching to false for thread and pull request
Loading

Suggested reviewers: juliusmarminge, maria-rcks

Merge Risk: ⚪ Minimal · up to 97b94

The new eye control appears usable from the badge hover card, with no confirmed issue preventing merge after normal checks.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 42.86% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 7 functions across 3 files. (1 skipped: 1… Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: showing and stopping pull-request watches from the PR hover card.
Description check ✅ Passed The description explains the problem and change, includes UI screenshots, and reports focused verification. It does not state the scope approval or explain why prior approval was not needed.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 42.86% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 7 functions across 3 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
🧰 Additional context used
📚 Code guidelines (1)
AGENTS.md — auto-discovered

Comment @coderabbitai help to get the list of available commands.

@t3dotgg

t3dotgg commented Oct 5, 2026

Copy link
Copy Markdown
Member Author

Wrong surface. Superseded by a new PR that adds the watch indicator to the thread details card.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

macroscope-review Opt PRs made by unvouched contributors in for Macroscope review. Vouched contributors auto-reviews size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants