fix(acp): preserve tool metadata across partial updates

[maria-rcks]

Titleless ACP tool completion updates replaced the original tool name with a fallback. Preserve the original name and kind when omitted, while emitting explicit kind and location changes immediately.

Base chain: #16021 → #16074 → #16075. gh stack link was attempted; GitHub rejects native stacks containing fork PRs. Registry and local launch resolution are unchanged.

Verified: 113 existing runtime/extension tests, scoped lint (0 errors), server typecheck on Blacksmith. Real isolated dsh conversations using ["codex","gpt-6.1-sol"] and ["opencode-go","deepseek-v4.1-flash"] completed README read/edit/readback with preserved tool names. An existing official OpenCode registry provider completed the same flow. The Go run also used Bash. Screenshots show comparable read/edit/read workloads before and after.

current-head verification on 761a16874e: Parent service fixes are integrated; this PR's own typed-form or tool-metadata behavior is unchanged. Both independent reviewers approved all three exact stack heads. Blacksmith passed 51 focused catalog/adapter/websocket tests, scoped lint, and server typecheck on integrated head 2d718dba8b. The real websocket uninstall preserved a referenced registry provider. Fresh dsh Codex and OpenCode Go read/edit/readback runs completed, and official OpenCode completed a file-tool conversation. Sanitized current-head runtime proof. The final one-line change makes the internally used catalog error guard private. Blacksmith passed the server export check, changed-file lint (0 warnings/errors), and 37 catalog tests on 761a16874e; the preceding behavior checks above passed on 2d718dba8b. Desktop shell and native mobile interaction remain unverified.

Model: gpt-6.1-sol. Harness: Codex through T3 Code.

[macroscopeapp]

Approvability

Verdict: Approved at 761a168

Macroscope's review found this PR approvable — The change is a focused ACP bug fix that preserves existing tool names and emits bounded metadata updates promptly, with no schema, deployment, security, billing, default, or lint/type-check configuration impact. The accompanying registry change only narrows an internal helper’s visibility.

Notes:

• All code in this push has already been reviewed. Approvability was decided on eligibility alone.

^{You can add or adjust custom eligibility rules. Learn more.}

Dismissing prior approval to re-evaluate 792d99b

[maria-rcks]

Note

Written by gpt-6.1-sol on behalf of Maria

the latest approvability comment cites local-agent auth coordination. those fixes belong to parent #16021 and are already in this pr's updated base, f6b857a. the base-to-head diff here remains two runtime/model files, +80/-7, preserving partial tool metadata; it contains no authentication changes. the original registry credential keys remain unchanged, and the parent fix separates local keys to prevent an unrelated instance's sessions from being stopped.

both independent reviewers approved be58ba7, f6b857a, and 792d99b after checking these fixes. 196 focused existing tests, scoped lint, and server typecheck passed on blacksmith. fresh codex/go/registry conversations and exact integer web-to-provider checks passed, with evidence in the updated bodies. native mobile and desktop-shell interaction remain unverified. human review of the stack's auth-sensitive parent remains with the maintainers; no review bot was invoked or review settings changed.

Dismissing prior approval to re-evaluate 761a168