Skip to content

fix(server): skip native sessions during bulk import - #15634

Open
maria-rcks wants to merge 2 commits into
pingdotgg:mainfrom
maria-rcks:fix/round2-wide-10933
Open

maria-rcks wants to merge 2 commits into
pingdotgg:mainfrom
maria-rcks:fix/round2-wide-10933

Conversation

@maria-rcks

@maria-rcks maria-rcks commented Oct 4, 2026 •

Copy link
Copy Markdown
Collaborator

bulk import could publish a second thread for a claude or codex session already owned by t3, including archived and deleted originals. the v2 event sink now rechecks ownership in the same provider instance inside the publication transaction. owned sessions create no history or new runtime row and count as neither imported nor failed, so onboarding keeps the selected landing project without a false import warning. ordinary imports and retries recover resume metadata without replaying history; genuine scan and write failures still count as skipped.

rebuilds the ownership and retry guarantees from #10950 for v2. existing duplicates and cross-environment deduplication remain outside this fix.

blacksmith verification: 169 tests passed (162 importer/scanner/foundation tests and 7 welcome-wizard tests); scoped lint and formatting passed; server and web typechecks passed. ownership counting regressions reproduced 24 failures before the fix. real provider transcript import, onboarding, and ui evidence remain unverified and parent-owned. final reviews for the updated head are pending.

Closes #10933

model: unknown-model, codex harness in t3 code.

@coderabbitai

coderabbitai Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

Only developers with an assigned seat can use this organization's usage-based review budget, and seats here are assigned manually. Ask an admin to assign a seat, or change the review continuation mode in Billing.

Next included review available in 20 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: pingdotgg/t3code/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a831e969-41e0-4b1f-bc59-63f190083c21
📥 Commits

Reviewing files that changed from the base of the PR and between 4ee6bfd and 2744869.

📒 Files selected for processing (4)
  • apps/server/src/orchestration-v2/EventSink.ts
  • apps/server/src/project/AgentSessionImporter.test.ts
  • apps/server/src/project/AgentSessionImporter.ts
  • apps/web/src/components/onboarding/WelcomeWizard.test.tsx
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Oct 4, 2026
@macroscopeapp

macroscopeapp Bot commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR changes the production bulk-import pipeline to conditionally suppress an entire native session, including its history and runtime setup, using a new transaction-time ownership check in shared event infrastructure. The behavior is well tested, but its cross-component gating and persistence-order changes warrant human review.

You can add or adjust custom eligibility rules. Learn more.

macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Oct 4, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Imported agent sessions duplicate T3-native threads: import dedup never consults the native thread namespace

1 participant