Repository navigation
fix(server): skip native sessions during bulk import - #15634
maria-rcks wants to merge 2 commits into
Conversation
|
Warning Review limit reachedOnly developers with an assigned seat can use this organization's usage-based review budget, and seats here are assigned manually. Ask an admin to assign a seat, or change the review continuation mode in Billing. Next included review available in 20 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (4)
Comment |
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This PR changes the production bulk-import pipeline to conditionally suppress an entire native session, including its history and runtime setup, using a new transaction-time ownership check in shared event infrastructure. The behavior is well tested, but its cross-component gating and persistence-order changes warrant human review. You can add or adjust custom eligibility rules. Learn more. |
Dismissing prior approval to re-evaluate 2744869
bulk import could publish a second thread for a claude or codex session already owned by t3, including archived and deleted originals. the v2 event sink now rechecks ownership in the same provider instance inside the publication transaction. owned sessions create no history or new runtime row and count as neither imported nor failed, so onboarding keeps the selected landing project without a false import warning. ordinary imports and retries recover resume metadata without replaying history; genuine scan and write failures still count as skipped.
rebuilds the ownership and retry guarantees from #10950 for v2. existing duplicates and cross-environment deduplication remain outside this fix.
blacksmith verification: 169 tests passed (162 importer/scanner/foundation tests and 7 welcome-wizard tests); scoped lint and formatting passed; server and web typechecks passed. ownership counting regressions reproduced 24 failures before the fix. real provider transcript import, onboarding, and ui evidence remain unverified and parent-owned. final reviews for the updated head are pending.
Closes #10933
model:
unknown-model, codex harness in t3 code.