Skip to content

fix(server): a missing agent binary no longer reads as a wrapper kill #15344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maria-rcks merged 2 commits into from
Oct 12, 2026
Merged

fix(server): a missing agent binary no longer reads as a wrapper kill #15344

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39b18b9
fix(server): a missing agent binary no longer reads as a wrapper kill
Moinax Oct 3, 2026
bdc0441
chore: update missing-agent fix with main
maria-rcks Oct 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/provider-acp/src/server/AcpSessionRuntime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,6 +285,13 @@ export function wrapCommandForLinuxCgroup(
'[ "$actual" = "$expected" ] || exit 126',
"unset ELECTRON_RUN_AS_NODE T3_ACP_CGROUP_WRAPPER",
"trap 'exit 125' 0",
// The trap alone does not cover a failed `exec`: bash — which is
// /bin/sh on Arch derivatives — exits 127 without running the EXIT
// trap, so a missing agent binary reported "killed by the wrapper"
// instead of "never launched". The caller always hands us an absolute
// target, so test it as an executable file rather than asking the
// shell to resolve it.
'[ -f "$1" ] && [ -x "$1" ] || exit 125',
'exec "$@"',
].join("\n"),
"t3-acp-cgroup-wrapper",
Expand Down
Loading