Repository navigation
fix(web): align semantic branch naming help with settings descriptions - #14998
esau-morais wants to merge 1 commit into
Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a small, self-contained presentation change that moves existing semantic branch-naming help into the settings row without changing defaults, persisted settings, or application behavior. The customer-specific human-review triggers are not involved. Notes:
You can add or adjust custom eligibility rules. Learn more. |
Dismissing prior approval to re-evaluate ccbc4fa
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe branch naming settings now show semantic-mode guidance with prefix examples. Other modes retain the general guidance. The separate semantic-mode explanation below the static-prefix setting was removed. ChangesBranch naming guidance
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~5 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to Semantic mode shows prefix examples, while other and mixed modes retain general guidance. No actionable user-facing or operational risk is established. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Just noticed it in the latest nightly 😂 Glad to see someone already took to it |
|
Note Grok responding on behalf of Julius. Superseded by merged #16972, which already landed the same semantic branch naming hint alignment fix. Closing this PR; please reopen if it still has unique changes beyond that fix. |
Problem
In Settings → Source Control → Text generation, selecting Semantic prefix puts “The model chooses…” against the card's left border. The standalone paragraph sits outside the padded setting row, uses larger text than neighboring descriptions, and gets its own separator.
Change
Use the Worktree branch naming row's
descriptionslot for semantic help, following the adjacent source control writing-style selector. This gives it the shared responsive padding, muted 12 px type, and wrapping. Static, custom, and mixed selections keep the general description.The change applies to web and the shared desktop UI. Native mobile already renders this help in its padded choice row. No setting behavior, provider, contract, or connection changes.
Scope and approval
This is a small, focused fix for an obvious layout bug, eligible for the documented exception without a prior issue or discussion. It reuses the existing settings layout and changes one component.
Verification
Followed
test-t3-appand the development runbook. Ran the real web client through T3's Browser panel against a disposable SQLite snapshot, separate from live state.858b98b8f. Before: helper x=345 and label x=361, with 14 px helper text. After: both x=361, with the shared 12 px description text.vp lint apps/web/src/components/settings/BranchNamingSettings.tsxpassed.vp fmt --check apps/web/src/components/settings/BranchNamingSettings.tsxpassed.vp run --filter @t3tools/web typecheckpassed.Desktop shell and native mobile were not run. Mixed-selection behavior was checked in source, not with multiple connected environments. No unit test was added for this presentation-only change.
390 px verification screenshot. Images are GitHub release assets on the fork; no evidence files are committed.
Model: GPT-6 Astra, high reasoning effort. Harness: Codex in T3 Code.
Fixes #16487