Skip to content

fix(web): align semantic branch naming help with settings descriptions - #14998

Closed
esau-morais wants to merge 1 commit into
pingdotgg:mainfrom
esau-morais:fix/settings-branch-naming-description
Closed

esau-morais wants to merge 1 commit into
pingdotgg:mainfrom
esau-morais:fix/settings-branch-naming-description

Conversation

@esau-morais

@esau-morais esau-morais commented Oct 3, 2026 •

Copy link
Copy Markdown

Problem

In Settings → Source Control → Text generation, selecting Semantic prefix puts “The model chooses…” against the card's left border. The standalone paragraph sits outside the padded setting row, uses larger text than neighboring descriptions, and gets its own separator.

Change

Use the Worktree branch naming row's description slot for semantic help, following the adjacent source control writing-style selector. This gives it the shared responsive padding, muted 12 px type, and wrapping. Static, custom, and mixed selections keep the general description.

The change applies to web and the shared desktop UI. Native mobile already renders this help in its padded choice row. No setting behavior, provider, contract, or connection changes.

Scope and approval

This is a small, focused fix for an obvious layout bug, eligible for the documented exception without a prior issue or discussion. It reuses the existing settings layout and changes one component.

Verification

Followed test-t3-app and the development runbook. Ran the real web client through T3's Browser panel against a disposable SQLite snapshot, separate from live state.

  • Reproduced the missing inset on upstream 858b98b8f. Before: helper x=345 and label x=361, with 14 px helper text. After: both x=361, with the shared 12 px description text.
  • Switched between semantic, static, and custom modes. Static retains its prefix input; custom retains its instructions editor; semantic help appears only in semantic mode.
  • Checked 390 px width: helper and label align at x=39, text wraps, and the row and document have no horizontal overflow.
  • vp lint apps/web/src/components/settings/BranchNamingSettings.tsx passed.
  • vp fmt --check apps/web/src/components/settings/BranchNamingSettings.tsx passed.
  • vp run --filter @t3tools/web typecheck passed.
  • React Doctor scanned the changed component. Its single control-flow complexity warning also appears on the unchanged baseline.

Desktop shell and native mobile were not run. Mixed-selection behavior was checked in source, not with multiple connected environments. No unit test was added for this presentation-only change.

Current Fix
Before: unpadded helper outside the setting row After: semantic help uses the standard setting description

390 px verification screenshot. Images are GitHub release assets on the fork; no evidence files are committed.

Model: GPT-6 Astra, high reasoning effort. Harness: Codex in T3 Code.

Fixes #16487

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Oct 3, 2026
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Oct 3, 2026
@macroscopeapp

macroscopeapp Bot commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at ccbc4fa

Macroscope's review found this PR approvable — This is a small, self-contained presentation change that moves existing semantic branch-naming help into the settings row without changing defaults, persisted settings, or application behavior. The customer-specific human-review triggers are not involved.

Notes:

  • Diff unchanged. Approvability was decided on eligibility alone.

You can add or adjust custom eligibility rules. Learn more.

@juliusmarminge juliusmarminge added the macroscope-review Opt PRs made by unvouched contributors in for Macroscope review. Vouched contributors auto-reviews label Oct 3, 2026 — with ChatGPT Codex Connector
@macroscopeapp
macroscopeapp Bot dismissed their stale review October 3, 2026 03:49

Dismissing prior approval to re-evaluate ccbc4fa

@coderabbitai

coderabbitai Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: pingdotgg/t3code/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b890fb21-b740-4e13-804b-49d883c7682f
📥 Commits

Reviewing files that changed from the base of the PR and between 858b98b and ccbc4fa.

📒 Files selected for processing (1)
  • apps/web/src/components/settings/BranchNamingSettings.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The branch naming settings now show semantic-mode guidance with prefix examples. Other modes retain the general guidance. The separate semantic-mode explanation below the static-prefix setting was removed.

Changes

Branch naming guidance

Layer / File(s) Summary
Mode-specific guidance
apps/web/src/components/settings/BranchNamingSettings.tsx
Semantic mode displays guidance about model-selected prefixes with examples. Other modes retain the general guidance. The separate semantic-mode paragraph was removed.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Suggested reviewers: juliusmarminge

Merge Risk: ⚪ Minimal · up to ccbc4

Semantic mode shows prefix examples, while other and mixed modes retain general guidance. No actionable user-facing or operational risk is established.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and concisely describes the change to semantic branch-naming help.
Description check ✅ Passed The description covers the problem, change, scope and approval rationale, and focused verification. It includes before-and-after screenshots and states which platforms and checks were not run.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@Neonsy

Neonsy commented Oct 3, 2026

Copy link
Copy Markdown

Just noticed it in the latest nightly 😂

Glad to see someone already took to it

@juliusmarminge

Copy link
Copy Markdown
Member

Note

Grok responding on behalf of Julius.

Superseded by merged #16972, which already landed the same semantic branch naming hint alignment fix. Closing this PR; please reopen if it still has unique changes beyond that fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

macroscope-review Opt PRs made by unvouched contributors in for Macroscope review. Vouched contributors auto-reviews size:S 10-29 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Worktree branch naming help text is misaligned in Settings

3 participants