Repository navigation
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a focused server-side bug fix that expands an existing Claude usage-event mapper to report all supported windows while preserving legacy behavior. The production impact is limited to more complete, fresher usage-limit telemetry, with targeted tests and no schema, deployment, authentication, billing, or default-setting changes. Notes:
You can add or adjust custom eligibility rules. Learn more. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: pingdotgg/t3code/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe Claude rate-limit event mapper now processes unified windows alongside legacy top-level fields. It validates utilization values, maps recognized windows, and returns all mapped updates. Tests cover conversion, precedence, and invalid or unknown entries. ChangesClaude usage limit event mapping
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The change updates supported Claude usage windows together while preserving legacy precedence and bounded percentages. No actionable merge-blocking risk remains after normal checks. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The change preserves the existing instance-specific update path and validates recognized usage windows. No new privileged action or security vulnerability was established. Remaining uncertainty concerns upstream data assumptions and lifecycle behavior, rather than a demonstrated boundary bypass. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
Resilience and Maintainability Implications
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Dismissing prior approval to re-evaluate dc1d8f3
fix(server): update all Claude unified usage windows
What Changed
Read every supported window from Claude Code's
rate_limit_info.unifiedWindows, keeping the existing top-level update authoritative for its window. Reuse the model-scoped bucket established by the usage probe and ignore malformed or unsupported entries.Why
Claude Code can emit session and weekly usage together without a top-level window. The existing mapper drops that event, leaving usage stale until the next probe. The CLI's own stream-json schema and print-mode serializer confirm the nested window names, utilization fractions, and camel-case
resetsAtfields.Validation
Synthetic fixtures follow the statically inspected Claude Code 2.1.281 serializer shape; they contain no captured account data. On unchanged main, the focused suite reports two regression failures and eight passing tests. With the fix, all ten tests pass using
vp test run apps/server/src/provider/Layers/claudeUsageLimits.test.ts --maxWorkers=2. Scoped lint, formatting, and a TypeScript check of the mapper/test import closure pass on Node 24.13.1. No live provider calls or UI verification were performed.Checklist
AI-assisted: implemented with GPT-6.1 Sol (Codex) and independently reviewed by Claude; human-approved before submission.