Repository navigation
Conversation
… the composer Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — The PR is a localized web composer bug fix that renumbers only the affected ordered-list run and preserves existing behavior for other composer paths. Its production changes are self-contained and accompanied by focused regression coverage, with no schema, deployment, security, billing, or static-analysis changes. Notes:
You can add or adjust custom eligibility rules. Learn more. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: pingdotgg/t3code/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughEnter continuation can renumber matching ordered-list items below the current item. List edits now return explicit caret offsets, which ChatComposer applies after Enter and Tab edits. ChangesComposer list editing
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The list-renumbering and caret updates have no identified merge-blocking issue. Mergeable after normal checks; runtime editor interaction was not independently exercised. Security Architecture ReviewSecurity architecture risk: ⚪ Minimal · up to The change remains within local composer editing. It preserves structured references, existing input restrictions, and submission behavior while correcting numbering and caret placement. No material security risk was identified. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Dismissing prior approval to re-evaluate d630285
…bers unpadded Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
d630285 to
3ba1166
Compare
|
Review requested
Logged so this PR shows when a maintainer was asked to review it. |
|
Review requested
Logged so this PR shows when a maintainer was asked to review it. |
What Changed
In the composer, Shift+Enter inside a numbered list now renumbers the items below the new one, not just the new item itself.
listContinuationForEnter(apps/web/src/composer-list-continuation.ts) now also rewrites the numbers of the ordered items that follow:01.) keep their width; others don't gain padding.The edit now carries an explicit expanded
cursorAfterso the caret still lands right after the new marker even though the replaced range extends past it. Tab uses the same field with its previous offset.Why
Put the caret at the start of an earlier item's text and press Shift+Enter to push it down. The pushed item gets the next number, but everything below keeps its old number, leaving duplicates (
1. 2. 3. 3.). Enter only ever inserted a single marker and never looked at later lines. Fixing it where the marker is inserted keeps both composer modes identical, because they share this store-replacement path.Bullets, tasks, the empty-item exit path, and non-list lines behave as before.
UI Changes
Fresh attached-preview verification on disposable data. Same project, list and viewport on current main c18e5ea and clean candidate d630285. At the end of item 2, press Shift+Enter and type into the inserted item.
Before (current main): the following item keeps 3, leaving duplicate numbers.
After (candidate): the following item becomes 4; typing stays in the inserted item.
Full recordings: before · after. GIFs show the first seven seconds sampled at 10 fps, at real-time speed, cropped to the full composer and heading. Recordings retain the full viewport. Screenshots: before · after.
Verification
Original implementation: Claude Sonnet 5.5 and Claude Opus 5.5 in Claude Code. Readiness audit: GPT-6.1 Sol through Codex. Independent review and attached-preview verification: GPT-6 Astra through Codex in T3 Code.