Repository navigation
Conversation
saphid
force-pushed
the
agent/v2-ingest-nonfatal-upstream
branch
from
September 30, 2026 14:10
6761b7f to
371bc63
Compare
Member
|
Note This comment is posted by Julius' dot This changes schema-rejected snapshots from a failed run into best-effort continuation, which can leave missing output, stale state or pending child prompts. The reported SQLite incident is handled separately in #14365. Could a maintainer confirm that this skip-and-continue policy is the intended direction, and its acceptable limits? Please link that decision under prior approval. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A schema-invalid provider snapshot currently ends root-run ingestion even when the provider can continue. This change logs and skips schema-rejected message, turn-item, node, subagent, plan, provider-thread, and provider-turn snapshots. Later valid snapshots can restore those entities while ingestion remains active.
Terminal, thread-creation, and runtime-request errors retain the existing failure path, as do storage failures, other normalization errors, defects, and interruption. Rejected snapshots do not create background ownership or extend ingestion past root completion.
Recovery is best effort: skipped snapshots have no durable rejection record and may leave missing output, stale state, or pending child prompts without a valid replacement. A rejected settled snapshot for an already-tracked child can retain its subscription until the session is released. Warnings are logged per rejection. There is no confirmed production schema-rejection incident; the motivating SQLite failure is addressed separately by #14365.
Verified with 171 tests across four focused files, server typecheck, and lint/format checks on the three changed files. Regression tests reproduce malformed lone-terminal, child-creation, and runtime-request failures before the repair and pass afterward. Independent review reran the 70 ingestor/execution tests and found no blocking code findings. This backend-only change has no visual behavior to demonstrate.
Current CI limitation: six jobs in run 36727099830 failed during Vite+ installation after four attempts, before their checks/tests ran. Rerunning failed jobs was rejected because this account lacks repository admin rights. The PR remains a draft pending a successful current-head CI run.
Readiness repairs: GPT-6 Astra in the Codex harness through T3 Code. Independent review: Anthropic Claude Fable 5.1, high reasoning, Claude Code harness through T3 Code.