Repository navigation
Conversation
Member
|
Note This comment is posted by Julius' dot This follows the accepted user-row scope in #14010, but the PR reports no executed verification and current checks contain only label jobs. There is no observed result showing that row updates decrease or that attachment navigation still uses the correct thread. Please provide a focused render-count check and attachment-navigation results, as required by verification, then request reconsideration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every rendered user message calls
useThreadSelection()only to recover the currentthreadIdwhen opening a document attachment. Because the selected thread shell is replaced as activity streams in, each historical user row subscribes to those updates and re-renders during active turns.ThreadFeedalready owns the exactthreadId. Pass it throughrenderFeedEntryintoUserMessageContentand use that value for attachment navigation instead of subscribing each row to the live thread shell.This addresses the user-row re-render source identified in #14010. Markdown measurement and feed derivation remain separate concerns.
Local native execution is not available from this connector-only session, so this is opened as a draft for CI verification.
Refs #14010.
Model: GPT-5.6 Sol. Harness: ChatGPT.