Repository navigation
Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a focused iOS mobile bug fix that clears stale navigation chrome during layout transitions and preserves sidebar rendering without changing Android, data contracts, or production infrastructure. The limited two-file scope and localized visual impact make it suitable for approval. No code changes detected at You can add or adjust custom eligibility rules. Learn more. |
|
Reviewed CodeRabbit's advisory docstring-coverage warning. The repository does not configure an 80% docstring requirement. Both non-obvious parts of this change already have nearby comments: UIKit glass must not inherit the sidebar fade, and Home's navigation options survive layout transitions. Adding component docstrings solely to satisfy the percentage would repeat the implementation, contrary to AGENTS.md's guidance. Leaving those unchanged. CodeRabbit reported no actionable code findings for |
9268e1e to
7322940
Compare
7322940 to
2be4c92
Compare
2be4c92 to
16cae41
Compare
|
@juliusmarminge @maria-rcks This is rebased onto current |
Resizing an iPad from the two-column layout to one column and back removes the Liquid Glass backgrounds from the sidebar search field and header buttons. The empty detail pane can retain the compact layout's search toolbar and settings button.
Keep the iOS sidebar fully opaque while its clipped width animates. UIKit visual effects can fail when an ancestor fades through zero opacity; the sidebar width already controls its reveal. Clear Home's compact search and toolbar options when it becomes the empty split detail pane. Android keeps its existing fade.
Independent of #13085 (shared filters), #11057 (native search field reuse/width after resizing), and #10629 (toolbar clipping). This targets main directly and has no merge-order dependency.
Scope and approval
This is submitted under the small, focused bug-fix exception. The recorded iPad resize regression drops existing sidebar glass and leaves compact controls in the empty split pane. The fix restores that chrome through the existing layout transition, with two local adjustments to opacity and header options.
Before / After
iPad 11-inch Simulator, iOS 26.5, dark theme, same native client and isolated showcase data. Both images show the return to the two-column layout.
Before recording · After recording: repeated resize · Light theme after resizing
Verification
d06f0ff104; verified this fix in the same iOS 26.5 native development client.git diff --checkpass. Scoped lint reports only four existing warnings.Model: GPT-6 Astra | Harness: Codex in T3 Code