Repository navigation
fix(web): offer Stop while a v2 run is still starting - #13433
Closed
violetweather wants to merge 656 commits into
Closed
violetweather wants to merge 656 commits into
violetweather wants to merge 656 commits into
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…8464) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…0051) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Julius Marminge <julius0216@outlook.com>
Keep main's recycled mobile list and per-row clock scoping alongside V2 runtime ownership, subagent filtering, and unread completion labels. Preserve provider compatibility diagnostics and shared PR badge controls while retaining V2 authentication actions and linked-PR tooltips. Port main's PR batching and settlement quota improvements into the V2 services.
…13311) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…erk bridge (#13204) Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…3347) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
A run stuck preparing or starting showed a disabled send spinner and no Stop, even though run.interrupt settles such a run before its provider turn begins. Refs #13392
github-actions
Bot
added
vouch:unvouched
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a small, self-contained web UI bug fix that exposes the existing Stop action during supported preparing/starting states. It does not alter defaults, backend workflows, schemas, infrastructure, or static-analysis configuration. You can add or adjust custom eligibility rules. Learn more. |
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
juliusmarminge
force-pushed
the
t3code/codex-turn-mapping
branch
3 times, most recently
from
September 25, 2026 05:55
fe4f6ad to
87c67bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
The desktop/web composer now offers Stop for a run that is still
preparingorstarting, the same setthreadRuntimeHasInterruptibleRunalready uses on mobile. While such a run is active, Stop replaces the disabled send spinner. Thethread.stopshortcut uses the same check.queuedis not included, sincerun.interruptrejects it.Why
Part 2 of #13392.
derivePhasemapspreparing/startingto"connecting", and Stop was only offered for"running". A run stuck instartingtherefore had no way to stop it from the desktop, even thoughrun.interruptalready settles such a run ("Run interrupted before provider start").The server part of #13392 is a separate PR.
UI Changes
Reproduced with a stand-in
pibinary that exits during the turn start, as described in the issue.Before: a stuck
startingrun shows a disabled spinner and no Stop.After: the same thread offers Stop.
After pressing Stop: the run is interrupted before provider start and the thread is no longer working.
Checklist
Ran
vp lintandvp fmt --checkon the changed files,tsc --noEmitforapps/web, and the existingComposerPrimaryActionsandthreadExecutiontests. Mobile already offers Stop for these states.Done with Claude Code (Claude Opus 5.5).