Skip to content

fix(models): make gpt-6-sol and gpt-6-luna current - #13105

Closed
AJJPostma wants to merge 1 commit into
pingdotgg:mainfrom
AJJPostma:gpt-6-models
Closed

AJJPostma wants to merge 1 commit into
pingdotgg:mainfrom
AJJPostma:gpt-6-models

Conversation

@AJJPostma

@AJJPostma AJJPostma commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

What Changed

In currentModels.codex, replaces gpt-5.6-sol and gpt-5.6-luna with gpt-6-sol and gpt-6-luna, and bumps updatedAt. Data-only change, same shape as #9762 for GPT-6-Astra.

Why

Codex discovers its own model list, and currentModels.codex is only the legacy-classification overlay. A newly released model that isn't listed there is discovered correctly but shown under Legacy models, which is wrong for a current model. The superseded gpt-5.6-sol and gpt-5.6-luna fold into Legacy models, still selectable, the same treatment older Codex models get.

Verified against the live Codex app server (model/list) on codex-cli 0.155.0: both are advertised today as gpt-6-sol ("GPT-6-Sol", efforts low/medium/high/xhigh/max/ultra, default medium) and gpt-6-luna ("GPT-6-Luna", efforts low/medium/high/xhigh/max, default medium).

Nothing else changes: no aliases are repointed and no defaults are changed, so existing selections keep working.

Verification

  • vp test run apps/server/src/provider/ModelManifest.test.ts apps/server/src/provider/ClaudeModelCatalog.test.ts
  • vp fmt --check on the manifest.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes (n/a: manifest data only)
  • I included a video for animation/interaction changes (n/a)

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Updates
    • Updated the available Codex model names to gpt-6-luna and gpt-6-sol.
    • Refreshed the model catalog timestamp.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Sep 22, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 270140a

Macroscope's review found this PR approvable — This is a three-line manifest correction that updates Codex model classification without changing defaults, model execution, aliases, or schemas. Its runtime impact is limited to moving the renamed models between current and legacy presentation groups.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Sep 22, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: pingdotgg/t3code/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: eaa73d73-8090-45ef-88a7-ff9b5c4dea80

📥 Commits

Reviewing files that changed from the base of the PR and between f25a8e4 and 270140a.

📒 Files selected for processing (1)
  • apps/server/src/provider/model-manifest.json

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The model manifest timestamp was refreshed. Two Codex model identifiers changed from gpt-5.6-* to gpt-6-*. The other listed models remain unchanged.

Changes

Codex model manifest

Layer / File(s) Summary
Update manifest metadata and model identifiers
apps/server/src/provider/model-manifest.json
The updatedAt timestamp was refreshed. gpt-5.6-luna and gpt-5.6-sol were renamed to gpt-6-luna and gpt-6-sol.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Suggested reviewers: juliusmarminge

Merge Risk: ⚪ Minimal · up to 27014

The manifest-only model refresh is ready to merge.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely identifies the primary change: updating the current model entries for gpt-6-sol and gpt-6-luna.
Description check ✅ Passed The description includes the required What Changed and Why sections, explains the model classification behavior, documents verification, and provides the checklist. UI evidence is correctly marked not…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@Gigioxx

Gigioxx commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

let's go!

@f4llenz

f4llenz commented Sep 22, 2026

Copy link
Copy Markdown

Send itttt

@AJJPostma

Copy link
Copy Markdown
Contributor Author

superseded by 17e3477 on main, which already marks gpt-6-sol and gpt-6-luna current. closing.

@AJJPostma AJJPostma closed this Sep 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants