Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 51 additions & 0 deletions apps/server/src/provider/Layers/OpenCodeAdapter.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import * as NodeAssert from "node:assert/strict";
import * as NodeServices from "@effect/platform-node/NodeServices";
import { it } from "@effect/vitest";
import * as Cause from "effect/Cause";
import * as Clock from "effect/Clock";
import * as Context from "effect/Context";
import * as Crypto from "effect/Crypto";
import * as Deferred from "effect/Deferred";
Expand Down Expand Up @@ -781,6 +782,56 @@ it.layer(OpenCodeAdapterTestLayer)("OpenCodeAdapterLive", (it) => {
}),
);

it.effect(
"stopSession completes after sendTurn is interrupted before the prompt is submitted",
() =>
Effect.gen(function* () {
const adapter = yield* OpenCodeAdapter;
const threadId = asThreadId("thread-opencode-interrupted-before-submit");
runtimeMock.state.createdSessionIds.push("ses_interrupted_before_submit");
yield* adapter.startSession({
provider: ProviderDriverKind.make("opencode"),
threadId,
runtimeMode: "full-access",
});

const baseClock = yield* Clock.clockWith(Effect.succeed);
const reached = yield* Deferred.make<void>();
const release = yield* Deferred.make<void>();
let calls = 0;
const gatedClock: Clock.Clock = {
...baseClock,
currentTimeMillisUnsafe: () => baseClock.currentTimeMillisUnsafe(),
currentTimeMillis: Effect.suspend(() => {
calls += 1;
return calls === 2
? Deferred.succeed(reached, undefined).pipe(
Effect.andThen(Deferred.await(release)),
Effect.andThen(baseClock.currentTimeMillis),
)
: baseClock.currentTimeMillis;
}),
};

const sendFiber = yield* adapter
.sendTurn({
threadId,
input: "This prompt must not be submitted",
modelSelection: createModelSelection(
ProviderInstanceId.make("opencode"),
"opencode/kimi-k3",
),
})
.pipe(Effect.provideService(Clock.Clock, gatedClock), Effect.exit, Effect.forkChild);
yield* Deferred.await(reached);
yield* Fiber.interrupt(sendFiber);

const stopExit = yield* adapter.stopSession(threadId).pipe(Effect.exit);
NodeAssert.equal(Exit.isSuccess(stopExit), true);
NodeAssert.equal(yield* adapter.hasSession(threadId), false);
}),
);

it.effect("aborts a held teardown request before closing the session scope", () =>
Effect.gen(function* () {
const adapter = yield* OpenCodeAdapter;
Expand Down
13 changes: 12 additions & 1 deletion apps/server/src/provider/Layers/OpenCodeAdapter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3531,7 +3531,18 @@ export function makeOpenCodeAdapter(
? { resumeCursor: context.session.resumeCursor }
: {}),
};
}),
}).pipe(
// stopSession waits on submissionSettled; an interrupted sendTurn
// must not leave it pending.
Effect.ensuring(
Effect.suspend(() => {
const admission = context.promptAdmission;
return admission
? Deferred.succeed(admission.submissionSettled, undefined).pipe(Effect.ignore)
: Effect.void;
}),
),
),
);
});

Expand Down
Loading