Fixed pin error text and cleaned up copied mobile helpers

[kridaydave]

PR made by muse-spark-1.3-contributor from opencode on behalf of Kriday.

Pin failure showed [object Object] when the cause was not an Error. Now it shows the real message with a plain fallback, matching the move thread branch. The rest is small cleanup with no behavior change.

Summary:

• Show real pin error text with fallback instead of String(Cause.squash())
• Drop stray empty string arg in agent awareness debug log
• Share one review diff log helper instead of two copies
• Share one review perf measure helper for sync and async

Summary by CodeRabbit

• New Features

  • Added the ability to rename threads directly from the thread list.
  • Prompts for a new title and prevents empty or unchanged names from being submitted.

• Bug Fixes

  • Improved error alerts when moving threads between sections, providing clearer, more human-readable messages.
  • Refined diagnostic logging so messages without additional details no longer include an empty value.

• Refactor

  • Standardized review performance measurement and diagnostic handling while preserving existing behavior.

[cursor]

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

[macroscopeapp]

Approvability

Verdict: Approved at bffb963

Macroscope's review found this PR approvable — The PR is limited to a clearer existing pin-failure alert and behavior-preserving cleanup of mobile diagnostic logging. It introduces no new capability, schema or deployment change, product-default change, or static-analysis suppression.

No code changes detected at 83c62a4. Prior analysis still applies.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: c1ba5ad9-fb10-404d-895f-817672389508

📥 Commits

Reviewing files that changed from the base of the PR and between 65491ec and 20b4be2.

📒 Files selected for processing (1)

• apps/mobile/src/features/home/useThreadListActions.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.

---

📝 Walkthrough

Walkthrough

The changes add thread renaming, share review performance and diagnostic helpers, and adjust registration debug logging when details are absent.

Changes

Thread renaming

Layer / File(s)	Summary
Rename thread action apps/mobile/src/features/home/useThreadListActions.ts	The hook prompts for a title, validates it, skips empty or unchanged titles, updates thread metadata, and reports mutation failures.

Review performance measurements

Layer / File(s)	Summary
Shared measurement lifecycle apps/mobile/src/features/review/reviewPerf.ts	Synchronous and asynchronous measurements use shared start and finish helpers while preserving callback execution, timing, cleanup, and logging.

Review diagnostic logger sharing

Layer / File(s)	Summary
Shared review diagnostic logging apps/mobile/src/features/review/useReviewDiffData.ts, apps/mobile/src/features/review/useNativeReviewDiffHighlighting.ts	logReviewDiffDiagnostic is exported and used by the native highlighting hook instead of a local implementation.

Registration logging

Layer / File(s)	Summary
Registration log output apps/mobile/src/features/agent-awareness/remoteRegistration.ts	Registration logs omit the details argument when it is undefined.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix

Sequence Diagram(s)

sequenceDiagram
  participant User
  participant useThreadListActions
  participant resolveThreadTitleRename
  participant updateThreadMetadata
  User->>useThreadListActions: enter new title
  useThreadListActions->>resolveThreadTitleRename: resolve requested rename
  resolveThreadTitleRename-->>useThreadListActions: valid title or validation result
  useThreadListActions->>updateThreadMetadata: submit new title
  updateThreadMetadata-->>useThreadListActions: success or failure

Loading

Suggested reviewers: juliusmarminge

Merge Risk: ⚪ Minimal · up to 20b4b

The thread rename flow remains validated, while the measurement and diagnostic changes preserve existing behavior. No merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 16.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 12 functions across 5 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the pin error text fix and the related mobile helper cleanup. It is concise and relevant.
Description check	✅ Passed	The description explains the main changes and the reason for them. It omits the template headings, checklist, and UI evidence for the added rename interaction, but the required content is mostly prese…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[cursor]

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

Dismissing prior approval to re-evaluate 652a7cb

Dismissing prior approval to re-evaluate c66117a

[kridaydave]

Docstring coverage note: added one-liners to the two new helpers (start/finishReviewMeasure). The other flagged functions are pre-existing private debug/perf helpers this PR only touched in passing, and they match the undocumented style of the surrounding files. Leaving them as-is rather than adding filler comments to chase the percentage.

[cursor]

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

[cursor]

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

[kridaydave]

@juliusmarminge If you are free can you have a look at this PR? Has been open for a week for simple error fix.

Dismissing prior approval to re-evaluate bffb963

[macroscopeapp]

All clear

^{Posted via Macroscope — Effect Service Conventions}

[macroscopeapp]

All clear

^{Posted via Macroscope — Effect Service Conventions}