Repository navigation
Conversation
- Cache EnvironmentStore's decoded document; publishes read it several times per second and previously hit disk + JSON decode every time - Memoize parsed ISO8601 dates in NativeFeatureClient; every publish re-parsed ~10 timestamps per thread through two formatters - Cache the mapped provider catalog per environment, invalidated on server config writes, instead of rebuilding hundreds of structs per publish - Sort activity logs by raw ISO string instead of parsing dates inside the comparator (O(n log n) formatter calls per detail rebuild) - Skip attachment hydration entirely for text-only threads - Dedupe emitConnection so per-event yields only publish transitions - Early-out acknowledgeDeliveredMessages when the outbox is empty - Cap terminal buffers at 256KB; unbounded append could OOM on verbose commands and re-layout megabyte strings per chunk - Key the markdown document cache by content fingerprint instead of the whole source string, stop inserting streaming intermediates (which churned completed messages out), and promote the final streamed render on completion instead of reparsing on the main thread - Throttle streaming markdown renders (150ms leading-edge) instead of a 200ms trailing debounce that never fired at an 80ms publish cadence, which left streaming messages as plain text for whole turns - Share JSONEncoder/Decoder.t3 instances (were rebuilt per call) and skip sortedKeys on throwaway JSONValue bridging encodes - Weak-capture the RPC connection loop and keepalive so released clients can actually deinit; snapshot dictionary keys before reentrant iteration in connected(); scope subscription Interrupts to the connection that assigned the request ID; add reconnect jitter - Cache DPoP JWK + thumbprint (SHA-256 per managed request before) and the proof encoder; reuse ISO8601 formatter in command builders - Replace crash-prone Dictionary(uniqueKeysWithValues:) on server-supplied IDs with first-wins reduces (model picker, agent awareness); retain per-thread states instead of full FeatureThread copies for transition signals; idle the home list timer to 60s when nothing is working Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
- Move table column-width estimation into the background render pass and store it on MarkdownRenderedTable; the view measured every cell's AttributedString per body evaluation on the main thread - Make rendered markdown blocks Equatable (inline runs compare by reference thanks to the streaming run cache) and wrap block views in .equatable(), so only the changed tail of a streaming message re-renders instead of every block - Gate the thread header's per-second TimelineView on working status; idle threads render a static status - Decode local attachment previews off-main through the shared thumbnail cache; UIImage(data:) ran in body per reconfigure - Memoize composer trigger parsing (was parsed 4x per keystroke) - Drop markdown caches on memory warnings - Stop the QR capture session on viewDidDisappear/backgrounding and resume on reappear; dismantle was the only stop path - Retry pending workspace navigation requests when snapshot data lands so cold-start deep links are not silently dropped - Scope approval/user-input resolution to details that contain the request instead of deep-comparing every cached transcript - Binary-search diff hydration anchors (was O(n^2) on large files) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…-app-swift # Conflicts: # .agents/skills/test-t3-mobile/SKILL.md # docs/user/appearance.md
URLComponents.percentEncodedQuery leaves "+" unescaped, but the server decodes /oauth/token posts with form semantics where "+" means space. Escape it as %2B in all three form-encoded token exchange bodies: PairingService (pairing code and client label), and the two T3 Connect formEncoded helpers that post bootstrap credentials and client labels.
saphid
force-pushed
the
pr/swiftui-pairing-form-20260908
branch
from
September 26, 2026 13:33
3708ab4 to
cfc8bbe
Compare
juliusmarminge
added
the
macroscope-review
ChatGPT Codex Connector
t3dotgg
force-pushed
the
t3code/rebuild-mobile-app-swift
branch
2 times, most recently
from
October 1, 2026 21:36
1637f70 to
cf79028
Compare
Member
|
Note 🤖 GPT-6.1-Sol responding on behalf of Theo Applied the focused fix to The source branch includes old rewrite history that conflicts with the current target. Only the intended fix and its focused tests were carried over. The combined focused native checks passed: 241 tests, one existing skip, no failures. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Literal
+characters in pairing credentials or client labels became spaces when the server decoded SwiftUI's form-encoded request. Escape remaining plus signs as%2Bafter Foundation encodes each field.The fix covers direct pairing and managed environment authorization at
/oauth/token, plus the relay's Clerk JWT exchange at/v1/client/dpop-token. It leaves existing percent escapes and the authentication/retry policy intact.The Swift target was rewritten to 285d2ab8. GitHub now reports conflicts. The native results below cover the earlier 157476f1 base; integration and native verification against the rewritten target remain pending.
Historical verification: native CI passed all 6 PairingService and 35 T3ConnectRuntime cases, including both new request-body round-trip regressions. The tested merge tree is identical to cfc8bbe against the earlier Swift target 157476f. Fresh independent source review found no blocking correctness issue. The new cases follow their existing XCTest suites; review noted a nonblocking preference for Swift Testing.
No local native rerun or live auth/relay journey is claimed. This is a request-serialization change with no layout or control changes. The separate URL-parser repairs in #10743 remain independently scoped and have not been runtime-tested in combination here.
Model and harness: GPT-6 / Codex (original implementation); GPT-6 Astra / Codex in T3 (readiness audit and description); GPT-6.1 Sol, high / Codex through T3 (fresh independent review).