Repository navigation
[Bug]: Model picker assigns duplicate keyboard shortcuts #4432
Description
Activity
Reproduced the stale shortcut-label behavior and verified the fix in #4433 at
2b107b9f8a50dd7999e94a55f61509bdc7a1ed57.Using the same isolated web environment at a 390×844 viewport:
- Before (unfixed checkout): filtering the live model list to
opusleaves cached rows with their old full-list shortcuts (Ctrl+2throughCtrl+6) instead of reassigning them from the filtered positions. - After (PR head): the same flow refreshes every row to unique positional shortcuts
Ctrl+1throughCtrl+5.
Before — stale cached labels
After — fixed positional labels
Focused regression test also passes:
vp test run apps/web/src/components/chat/ModelPickerContent.test.tsx Test Files 1 passed (1) Tests 1 passed (1)- Before (unfixed checkout): filtering the live model list to
Description
The model picker can display the same keyboard shortcut for two different models. In the observed list, both GPT-5.6-Sol and GPT-5.6-Luna are labeled
Ctrl+2, while GPT-5.6-Terra is labeledCtrl+3.Steps to reproduce
Actual behavior
Both models are assigned/displayed as
Ctrl+2, so the shortcut mapping is ambiguous and at least one model cannot be selected by the shortcut shown for it.Expected behavior
Each shortcut-enabled model should receive a unique shortcut that corresponds to its displayed position/order.
Additional context
Observed in the collapsed mobile/narrow layout, though the issue appears to be shortcut assignment rather than menu clipping.