SSH setup reports a missing compiler when the requested nightly is not yet published #10084

Activity

1. juliusmarminge commented on Sep 5, 2026

   

   juliusmarminge

   on Sep 5, 2026

   Member

   More actions

   Triage

   Confirmed. Desktop SSH asks the remote host for the exact packaged app version (t3@0.0.39-nightly.20260905.1286). When that version is not on npm yet, npx/npm exec fails with ETARGET, but require_installed_t3_cli treats “no t3 on PATH” as a successful install with a failed node-pty build.

   What happens

   Packaged (non-dev) desktop builds pin the remote CLI to the running app version:

   // packages/ssh/src/command.ts
   if (!input.isDevelopment && PUBLISHABLE_T3_VERSION_PATTERN.test(appVersion)) {
     return `t3@${appVersion}`;
   }

   Nightly 0.0.39-nightly.20260905.1286 matches that pattern, so SSH does not fall back to t3@nightly. The remote runner then preflights install like this:

   # packages/ssh/src/tunnel.ts — REMOTE_RUNNER_SCRIPT
   require_installed_t3_cli() {
     T3_CLI_PATH="$("$@" -- sh -c 'command -v t3' || true)"
     if [ -n "$T3_CLI_PATH" ]; then
       return 0
     fi
     printf 'Remote host installed %s but npm produced no t3 executable, which usually means a native dependency (node-pty) failed to build. …' …
     return 1
   }

   || true was added in #5132 so a successful npx --yes that exits 0 with no t3 binary (the real missing-compiler / node-pty case) still fails loudly. It also swallows real npm failures. Empty T3_CLI_PATH then always prints the compiler message, including for ETARGET.

   The reporter’s timeline matches that race: GitHub release 09:51:30 UTC, failed npm 09:57:00, npm publication 09:58:48. Evidence is consistent (ETARGET + the “installed … no t3 executable” line).

   Suggested fix

   Keep the #5132 empty-bin check, but branch on the install exit code:

   1. Capture npm/npx status instead of || true.
   2. If the command failed, report that the package could not be installed and leave npm’s stderr as the cause. Do not claim the package was installed or recommend a C toolchain.
   3. Emit the node-pty / compiler message only when the command exits 0 and still produces no t3 executable.

   packages/ssh/src/tunnel.test.ts currently only asserts that the compiler string is present. Cover the ETARGET / non-zero-install path so this cannot regress.

   Retrying or falling back to t3@nightly during the GitHub-release → npm-publish window is a separate product decision. The user-facing bug here is the misattribution.

   Workaround

   Reconnect after the exact version exists on npm. No remote toolchain change is required.

   Surfaces

   • Desktop SSH install of a pinned nightly/stable t3@<exact version>
   • Shared remote runner in packages/ssh (also used if other clients adopt the same script)
   • Not a provider, contracts, or mobile issue
2. juliusmarminge

   added

   via-triageFiled through npx t3 triageFiled through npx t3 triage

   bugSomething is broken or behaving incorrectly.Something is broken or behaving incorrectly.

   on Sep 5, 2026
3. juliusmarminge commented on Sep 5, 2026

   

   juliusmarminge

   on Sep 5, 2026

   Member

   More actions

   Fixed by #10088 (merged to main).
4. juliusmarminge

   closed this as completedon Sep 5, 2026
5. juliusmarminge commented on Sep 5, 2026

   

   juliusmarminge

   on Sep 5, 2026

   Member

   More actions

   Fixed on main by #10088, merged as 39802c06 on September 5, 2026.

   I reproduced the misleading diagnostic with the production-generated script and real /bin/sh, using controlled failing installers for both npx and npm exec. The fix checks the installer's exit status, preserves npm's stderr, and reports installation failure instead of recommending a compiler. The successful-install/no-executable safeguard remains. All 36 focused tests pass, including an independent run, and current-head CI passed.

   Closing the diagnostic bug. This does not change package publication timing or version selection, and I did not reproduce a complete SSH reconnect. If a current build still prints the wrong diagnostic, please open a new issue with its version and sanitized error output.

   Verified by GPT 6 Astra via Codex in T3 Code.