Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix drainer error node id message #925

Merged
merged 2 commits into from
Nov 23, 2020

Conversation

lucklove
Copy link
Member

What problem does this PR solve?

When drainer node id missing, it reports pump node id not found

What is changed and how it works?

Correct the error message

Check List

Related changes

  • Need to cherry-pick to the release branch

Release notes:

NONE

@lucklove lucklove added this to the v1.2.5 milestone Nov 20, 2020
@codecov-io
Copy link

codecov-io commented Nov 20, 2020

Codecov Report

Merging #925 (894c593) into master (cdc08cc) will decrease coverage by 3.79%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #925      +/-   ##
==========================================
- Coverage   55.23%   51.44%   -3.80%     
==========================================
  Files         261      261              
  Lines       19232    19234       +2     
==========================================
- Hits        10623     9894     -729     
- Misses       6902     7726     +824     
+ Partials     1707     1614      -93     
Flag Coverage Δ
cluster 38.30% <33.33%> (-5.22%) ⬇️
dm 24.13% <0.00%> (-0.01%) ⬇️
integrate 46.26% <33.33%> (-3.81%) ⬇️
playground 20.23% <0.00%> (-0.01%) ⬇️
tiup 17.13% <0.00%> (-0.01%) ⬇️
unittest 21.64% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/api/binlog.go 39.13% <33.33%> (+0.19%) ⬆️
components/cluster/command/check.go 6.37% <0.00%> (-72.82%) ⬇️
pkg/cluster/task/limits.go 0.00% <0.00%> (-68.75%) ⬇️
pkg/cluster/task/sysctl.go 0.00% <0.00%> (-66.67%) ⬇️
components/cluster/command/audit.go 27.27% <0.00%> (-54.55%) ⬇️
pkg/cluster/operation/check.go 0.00% <0.00%> (-51.95%) ⬇️
pkg/cluster/task/rmdir.go 0.00% <0.00%> (-50.00%) ⬇️
pkg/cluster/operation/operation.go 34.78% <0.00%> (-43.48%) ⬇️
components/cluster/command/rename.go 25.00% <0.00%> (-41.67%) ⬇️
components/cluster/command/stop.go 38.46% <0.00%> (-30.77%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdc08cc...894c593. Read the comment docs.

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 23, 2020
@AstroProfundis
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 23, 2020
@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 923

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 411f56c into pingcap:master Nov 23, 2020
@lucklove lucklove modified the milestones: v1.2.5, v1.2.6 Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants