Skip to content

Conversation

@Lloyd-Pottiger
Copy link
Contributor

What problem does this PR solve?

close #xxx

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

dveeden and others added 30 commits July 24, 2025 10:51
* Telemetry removal

* Remove left over teleCommand
* env: clean up old code

Signed-off-by: xhe <xw897002528@gmail.com>

* repo: leverage all apis into v1_repository

Signed-off-by: xhe <xw897002528@gmail.com>

* repo: abstract it as an interface

Signed-off-by: xhe <xw897002528@gmail.com>

* clean the remained part

Signed-off-by: xhe <xw897002528@gmail.com>

* rename to LocalComponentInstalled

Signed-off-by: xhe <xw897002528@gmail.com>

* update

Signed-off-by: xhe <xw897002528@gmail.com>

* try fix

Signed-off-by: xhe <xw897002528@gmail.com>

* g

Signed-off-by: xhe <xw897002528@gmail.com>

* try fix

Signed-off-by: xhe <xw897002528@gmail.com>

* g

Signed-off-by: xhe <xw897002528@gmail.com>

* g

Signed-off-by: xhe <xw897002528@gmail.com>

* g

Signed-off-by: xhe <xw897002528@gmail.com>

---------

Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
* cluster: improve SELinux compatibility

* fixup
* Update --ssh desc

* Update components/cluster/command/root.go

---------

Co-authored-by: xhe <xw897002528@gmail.com>
* Move insight to tiup

* Fix linting issues

* Fix unused/gocritic/staticcheck issues
* check_to_require: cluster

* Restore TestCountDirMultiPath

---------

Co-authored-by: xhe <xw897002528@gmail.com>
* Update dmpb

* Remove dm grpc gw
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
* ci: fix STAGING version competition

* ci: replace slashes with dots in branch name for STAGING_VER

* Apply suggestion from @wuhuizuo
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
* Switch from yaml.v2 to yaml.v3

* Use KnownFields

* Use KnowFields for a few more places that previously had UnmarshalStrict

* Fix issues found by make check

* Formatting differences in yaml

* update

* fix CI

Signed-off-by: xhe <xw897002528@gmail.com>

---------

Signed-off-by: xhe <xw897002528@gmail.com>
Co-authored-by: xhe <xw897002528@gmail.com>
* cluster: support new ready api for PD

Signed-off-by: xhe <xw897002528@gmail.com>

* try fix

Signed-off-by: xhe <xw897002528@gmail.com>

* try fix

Signed-off-by: xhe <xw897002528@gmail.com>

---------

Signed-off-by: xhe <xw897002528@gmail.com>
* cluster: clear leader_priority for pd leader if exist

Signed-off-by: xhe <xw897002528@gmail.com>

* fix

Signed-off-by: xhe <xw897002528@gmail.com>

---------

Signed-off-by: xhe <xw897002528@gmail.com>
* cluster: prompt for instance restart

* Add comment

* fixup

* fixup

* Split precheck from Upgrade
Signed-off-by: xhe <xw897002528@gmail.com>
dveeden and others added 21 commits November 11, 2025 10:42
* playground: fix metafile location

* g

Signed-off-by: xhe <xw897002528@gmail.com>

---------

Signed-off-by: xhe <xw897002528@gmail.com>
Co-authored-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
* playground: dont request mirror when binpath specified

Signed-off-by: xhe <xw897002528@gmail.com>

* add tikv worker

Signed-off-by: xhe <xw897002528@gmail.com>

---------

Signed-off-by: xhe <xw897002528@gmail.com>
* playground: refine nextgen version resolve

Signed-off-by: xhe <xw897002528@gmail.com>

* playgroud: support tiflash

Signed-off-by: xhe <xw897002528@gmail.com>

* fix version

Signed-off-by: xhe <xw897002528@gmail.com>

* fix

Signed-off-by: xhe <xw897002528@gmail.com>

---------

Signed-off-by: xhe <xw897002528@gmail.com>
* cluster: cleanup ansible import related things

* revert back missing code

Signed-off-by: xhe <xw897002528@gmail.com>

* fix test

Signed-off-by: xhe <xw897002528@gmail.com>

* remove ansible test

Signed-off-by: xhe <xw897002528@gmail.com>

---------

Signed-off-by: xhe <xw897002528@gmail.com>
Co-authored-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@ti-chi-bot ti-chi-bot bot requested review from breezewish and nexustar November 24, 2025 03:25
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bb7133 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 24, 2025
@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2025

Codecov Report

❌ Patch coverage is 45.51724% with 316 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (feature/fts@c5e8cee). Learn more about missing BASE report.

Files with missing lines Patch % Lines
components/playground/playground.go 43.09% 82 Missing and 21 partials ⚠️
components/playground/main.go 64.86% 25 Missing and 1 partial ⚠️
components/playground/instance/tiflash_config.go 0.00% 21 Missing ⚠️
components/playground/instance/tici.go 0.00% 19 Missing ⚠️
components/playground/instance/tidb_config.go 12.50% 14 Missing ⚠️
components/playground/instance/tikv_config.go 6.67% 14 Missing ⚠️
pkg/cluster/operation/destroy.go 0.00% 13 Missing ⚠️
pkg/exec/run.go 61.29% 8 Missing and 4 partials ⚠️
components/playground/instance/tikv_worker.go 0.00% 11 Missing ⚠️
pkg/repository/v1_repository.go 46.67% 8 Missing ⚠️
... and 30 more
Additional details and impacted files
@@              Coverage Diff               @@
##             feature/fts    #2650   +/-   ##
==============================================
  Coverage               ?   40.95%           
==============================================
  Files                  ?      370           
  Lines                  ?    37746           
  Branches               ?        0           
==============================================
  Hits                   ?    15457           
  Misses                 ?    20373           
  Partials               ?     1916           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@xhebox xhebox merged commit 5e178b3 into pingcap:feature/fts Nov 24, 2025
6 of 7 checks passed
@Lloyd-Pottiger Lloyd-Pottiger deleted the merge-master branch November 24, 2025 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants