cluster: clear leader_priority for pd leader if exist

pkg/cluster/api/pdapi.go

@@ -134,6 +134,7 @@ var (
 	pdLeaderURI          = "pd/api/v1/leader"
 	pdLeaderTransferURI  = "pd/api/v1/leader/transfer"
 	pdMembersURI         = "pd/api/v1/members"
+	pdMemberPriorityURI  = "pd/api/v1/members/name/%s"
 	pdSchedulersURI      = "pd/api/v1/schedulers"
 	pdStoreURI           = "pd/api/v1/store"
 	pdStoresURI          = "pd/api/v1/stores"
@@ -1035,6 +1036,17 @@ func (pc *PDClient) GetServicePrimary(service string) (string, error) {
 	return primary, err
 }
 
+// SetLeaderPriority sets priority config value of PD member.
+func (pc *PDClient) SetLeaderPriority(name string, value int32) error {
+	data := map[string]any{"leader-priority": value}
+	body, err := json.Marshal(data)
+	if err != nil {
+		return err
+	}
+	pc.l().Debugf("setting leader_priority for %s: %d", name, value)
+	return pc.updateConfig(fmt.Sprintf(pdMemberPriorityURI, name), bytes.NewBuffer(body))
+}
+
 const (
 	tsoStatusURI        = "status"
 	schedulingStatusURI = "status"

pkg/cluster/spec/pd.go

@@ -19,10 +19,12 @@ import (
 	"fmt"
 	"os"
 	"path/filepath"
+	"slices"
 	"strings"
 	"time"
 
 	"github.com/pingcap/errors"
+	"github.com/pingcap/kvproto/pkg/pdpb"
 	"github.com/pingcap/tiup/pkg/cluster/api"
 	"github.com/pingcap/tiup/pkg/cluster/ctxt"
 	"github.com/pingcap/tiup/pkg/cluster/template/scripts"
@@ -444,9 +446,30 @@ func (i *PDInstance) PreRestart(ctx context.Context, topo Topology, apiTimeoutSe
 		return err
 	}
 	if len(tidbTopo.PDServers) > 1 && isLeader {
+		members, err := pdClient.GetMembers()
+		if err != nil {
+			return err
+		}
+
+		var oldPriority int32
+		if m := slices.IndexFunc(members.Members, func(j *pdpb.Member) bool {
+			return i.Name == j.Name
+		}); m != -1 && members.Members[m].LeaderPriority != 0 {
+			oldPriority = members.Members[m].LeaderPriority
+		}
+
+		if oldPriority != 0 {
+			if err := pdClient.SetLeaderPriority(i.Name, 0); err != nil {
+				return errors.Annotatef(err, "failed to clear PD leader priority[%d] %s", oldPriority, i.GetHost())
+			}
+		}
 		if err := pdClient.EvictPDLeader(timeoutOpt); err != nil {
 			return errors.Annotatef(err, "failed to evict PD leader %s", i.GetHost())
 		}
+
+		if err := pdClient.SetLeaderPriority(i.Name, oldPriority); err != nil {
+			return errors.Annotatef(err, "failed to recover PD leader priority[%d] %s", oldPriority, i.GetHost())
+		}
 	}
 
 	return nil