Skip to content

Conversation

@dveeden
Copy link
Contributor

@dveeden dveeden commented Jul 13, 2025

What problem does this PR solve?

ref #2508

What is changed and how it works?

Switch back from forked go-pretty to upstream to make packaging and future maintenance easier

The fork was done because of the DoNotFillSpaceWhenEndOfLine option that was added. But it looks like t.SuppressTrailingSpaces() achieves the same. See also jedib0t/go-pretty#318

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below) (tiup list with narrow terminal window)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot bot requested review from breezewish and srstack July 13, 2025 09:02
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 13, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xhebox for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 13, 2025
@dveeden dveeden mentioned this pull request Jul 13, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.97%. Comparing base (751ef30) to head (5e83323).
Report is 2 commits behind head on master.

Current head 5e83323 differs from pull request most recent head 496def5

Please upload reports for the commit 496def5 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2560      +/-   ##
==========================================
+ Coverage   47.37%   47.97%   +0.60%     
==========================================
  Files         351      337      -14     
  Lines       37425    36710     -715     
==========================================
- Hits        17730    17611     -119     
+ Misses      17526    16936     -590     
+ Partials     2169     2163       -6     
Flag Coverage Δ
tiup 33.86% <100.00%> (+0.05%) ⬆️
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dveeden
Copy link
Contributor Author

dveeden commented Jul 13, 2025

/cc @xhebox

@ti-chi-bot ti-chi-bot bot requested a review from xhebox July 13, 2025 09:04
@ti-chi-bot ti-chi-bot bot added the lgtm label Jul 13, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 13, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-07-13 15:47:12.476163615 +0000 UTC m=+2446685.199342598: ☑️ agreed by breezewish.

@xhebox xhebox merged commit f1e790a into pingcap:master Jul 14, 2025
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants