Skip to content

Conversation

@breezewish
Copy link
Member

@breezewish breezewish commented May 6, 2025

What problem does this PR solve?

What is changed and how it works?

When --mode=tidb-cse, a fully functional tikv-worker process will be started as well (with remote compactor, remote cop and schema manager running).

Additionally, when --tikv.columnar is specified in this mode, TiKVColumnar query will be enabled (this brings all TiFlash Compute Node to read via TiKVColumnar).

Check List

Tests

  • Manual test
/Users/breezewish/Work/tiup/bin/tiup-playground v7.3.0 --mode=tidb-cse --tag serverless \
  --db.binpath ../tidb-cse/bin/tidb-server \
  --kv.binpath ../tikv-cse/target/release/tikv-server \
  --pd.binpath ../pd-cse/bin/pd-server \
  --tiflash.binpath ../tiflash-cse/cmake-build-Release/dbms/src/Server/tiflash \
  --tiflash.compute 1 --tikv.columnar

Release notes:

playground: Support tikv-worker and --tikv.columnar in tidb-cse mode

Signed-off-by: Wish <breezewish@outlook.com>
@ti-chi-bot ti-chi-bot bot requested review from kaaaaaaang and srstack May 6, 2025 15:23
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 6, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bb7133 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 6, 2025
@breezewish breezewish changed the title playground: Support tikv-worker and --tikv.columnar in CSE mode playground: Support tikv-worker and --tikv.columnar in tidb-cse mode May 6, 2025
Signed-off-by: Wish <breezewish@outlook.com>
@ti-chi-bot ti-chi-bot bot added the lgtm label May 8, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 8, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-05-08 06:45:16.054407545 +0000 UTC m=+510363.237310799: ☑️ agreed by xhebox.

@xhebox xhebox merged commit a521e92 into master May 8, 2025
19 of 20 checks passed
@xhebox xhebox deleted the wenxuan/tikv-columnar branch May 8, 2025 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants