Skip to content

Conversation

@nolouch
Copy link
Member

@nolouch nolouch commented Apr 21, 2025

What problem does this PR solve?

ref #2531

cluster: add agent mode for prometheus

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

Signed-off-by: nolouch <nolouch@gmail.com>
@ti-chi-bot ti-chi-bot bot requested review from kaaaaaaang and srstack April 21, 2025 10:32
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 21, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xhebox for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 21, 2025
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 28, 2025
@nolouch nolouch requested review from xhebox and removed request for kaaaaaaang and srstack April 28, 2025 09:51
Signed-off-by: nolouch <nolouch@gmail.com>
@ti-chi-bot ti-chi-bot bot added the lgtm label May 9, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 9, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-05-09 05:15:40.337754391 +0000 UTC m=+76606.485715606: ☑️ agreed by xhebox.

@xhebox xhebox merged commit 2a6bd31 into pingcap:master May 9, 2025
19 of 20 checks passed
@nolouch nolouch deleted the prometheus-agent branch May 12, 2025 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants