Move to 'go tool' and update revive etc

[dveeden]

What problem does this PR solve?

• Move to go tool for revive and failpoint
• Update golangci-lint
• The formatting changes have been made by golangci-lint

See also:

• https://go.dev/doc/go1.24#tools

What is changed and how it works?

Check List

Tests

• Manual test (add detailed scripts or steps below): make check

Release notes:

The minimum version of Go for building tiup has been changed to Go 1.24

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bb7133 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dveeden]

/cc @breezewish

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 13.55932% with 51 lines in your changes missing coverage. Please review.

Project coverage is 48.55%. Comparing base (e8c63c6) to head (e9eca5c).

❗ Current head e9eca5c differs from pull request most recent head 7bdecf8

Please upload reports for the commit 7bdecf8 to get more accurate results.

Files with missing lines	Patch %	Lines
pkg/cluster/manager/basic.go	0.00%	9 Missing ⚠️
pkg/cluster/operation/destroy.go	0.00%	9 Missing ⚠️
pkg/cluster/manager/destroy.go	0.00%	3 Missing ⚠️
pkg/cluster/manager/scale_in.go	0.00%	3 Missing ⚠️
pkg/cluster/spec/tikv.go	0.00%	3 Missing ⚠️
components/cluster/command/import.go	0.00%	2 Missing ⚠️
pkg/cluster/manager/upgrade.go	0.00%	2 Missing ⚠️
pkg/cluster/operation/action.go	33.33%	2 Missing ⚠️
pkg/cluster/operation/scale_in.go	33.33%	2 Missing ⚠️
pkg/proxy/proxy.go	0.00%	2 Missing ⚠️
... and 14 more

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2518      +/-   ##
==========================================
+ Coverage   45.65%   48.55%   +2.90%     
==========================================
  Files         337      350      +13     
  Lines       36436    37019     +583     
==========================================
+ Hits        16633    17971    +1338     
+ Misses      17774    16857     -917     
- Partials     2029     2191     +162     

Flag	Coverage Δ
cluster	35.31% <8.93%> (+3.72%)	⬆️
dm	25.13% <3.70%> (+6.22%)	⬆️
playground	16.17% <16.67%> (+5.83%)	⬆️
unittest	17.55% <1.69%> (-5.37%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[dveeden]

/cc @xhebox @bb7133

[xhebox]

Rest LGTM

[dveeden]

/retest

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2025-03-28 07:37:00.875149644 +0000 UTC m=+1205114.559385724: ☑️ agreed by breezewish.
• 2025-04-01 02:34:57.726231467 +0000 UTC m=+1532591.410467563: ✖️🔁 reset by xhebox.
• 2025-05-09 05:15:35.806871626 +0000 UTC m=+76601.954832844: ☑️ agreed by xhebox.