Skip to content

Conversation

@xhebox
Copy link
Collaborator

@xhebox xhebox commented Jan 18, 2024

What problem does this PR solve?

Some components has different Role() and Name(). FilterComponent is a mixed of filtering by Name() and Role(), thus we need to add both into the filter set.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

Signed-off-by: xhe <xw897002528@gmail.com>
@ti-chi-bot ti-chi-bot bot requested review from breezewish and srstack January 18, 2024 12:37
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 18, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.94%. Comparing base (bb648c3) to head (520a442).
Report is 1 commits behind head on master.

❗ Current head 520a442 differs from pull request most recent head 588189e. Consider uploading reports for the commit 588189e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2366      +/-   ##
==========================================
- Coverage   56.07%   55.94%   -0.13%     
==========================================
  Files         329      329              
  Lines       35034    35040       +6     
==========================================
- Hits        19644    19603      -41     
- Misses      13053    13100      +47     
  Partials     2337     2337              
Flag Coverage Δ
cluster 45.18% <100.00%> (-0.13%) ⬇️
dm 25.52% <100.00%> (-0.03%) ⬇️
playground 15.78% <ø> (ø)
tiup 33.59% <ø> (-0.05%) ⬇️
unittest 22.22% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xhebox
Copy link
Collaborator Author

xhebox commented Jan 18, 2024

/retest

@kaaaaaaang
Copy link
Collaborator

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 29, 2024
@kaaaaaaang
Copy link
Collaborator

/approve

@ti-chi-bot ti-chi-bot bot added the approved label Mar 6, 2024
@ti-chi-bot ti-chi-bot bot removed the lgtm label Mar 6, 2024
@kaaaaaaang
Copy link
Collaborator

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Mar 6, 2024
@kaaaaaaang
Copy link
Collaborator

/approve

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 6, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-29 09:56:13.554025538 +0000 UTC m=+1128662.301648646: ☑️ agreed by kaaaaaaang.
  • 2024-03-06 02:32:01.686474034 +0000 UTC m=+220748.708720422: ✖️🔁 reset by ti-chi-bot[bot].
  • 2024-03-06 07:54:02.920147684 +0000 UTC m=+240069.942394072: ☑️ agreed by kaaaaaaang.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 9e11d0e into pingcap:master Mar 6, 2024
@xhebox xhebox deleted the fix_2 branch March 6, 2024 08:25
@kaaaaaaang kaaaaaaang added this to the v1.15.0 milestone Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants