Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: fix tidb-dashboard listen_host #2304

Merged
merged 1 commit into from
Nov 8, 2023
Merged

cluster: fix tidb-dashboard listen_host #2304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion embed/templates/scripts/run_tidb-dashboard.sh.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ exec numactl --cpunodebind={{.NumaNode}} --membind={{.NumaNode}} bin/tidb-dashbo
exec bin/tidb-dashboard \
{{- end}}
--feature-version="{{.TidbVersion}}" \
--host="{{.IP}}" \
--host="{{.Host}}" \
--port="{{.Port}}" \
--pd="{{.PD}}" \
--data-dir="{{.DataDir}}" \
Expand Down
3 changes: 2 additions & 1 deletion pkg/cluster/spec/dashboard.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,8 +209,9 @@ func (i *DashboardInstance) InitConfig(
pds = append(pds, pdspec.GetAdvertiseClientURL(enableTLS))
}
cfg := &scripts.DashboardScript{
// -h, --host string listen host of the Dashboard Server
Host: i.GetListenHost(),
TidbVersion: clusterVersion,
IP: i.GetHost(),
DeployDir: paths.Deploy,
DataDir: paths.Data[0],
LogDir: paths.Log,
Expand Down
2 changes: 1 addition & 1 deletion pkg/cluster/template/scripts/dashboard.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import (
// DashboardScript represent the data to generate cdc config
type DashboardScript struct {
TidbVersion string
IP string
Host string
Port int
DeployDir string
LogDir string
Expand Down