Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display disaggregated mode #2133

Merged
merged 4 commits into from
Mar 15, 2023
Merged

display disaggregated mode #2133

merged 4 commits into from
Mar 15, 2023

Conversation

hehechen
Copy link
Contributor

@hehechen hehechen commented Mar 7, 2023

What problem does this PR solve?

What is changed and how it works?

#2135
When the label of TiFlash contains engine-role:write, it means that This TiFlash is a tiflash_write node. So tiflash_write should be displayed in tiup cluster display. But we don't support -R tiflash_write or tiflash_compute now, so just display tiflash (write) or tiflash (compute).

Check List

Tests

  • Unit test

  • Integration test

  • Manual test (add detailed scripts or steps below)
    image

  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

Signed-off-by: hehechen <awd123456sss@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 7, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 7, 2023
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 7, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.06 ⚠️

Comparison is base (c3c127f) 56.39% compared to head (afab5b8) 56.34%.

❗ Current head afab5b8 differs from pull request most recent head abbb58d. Consider uploading reports for the commit abbb58d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2133      +/-   ##
==========================================
- Coverage   56.39%   56.34%   -0.06%     
==========================================
  Files         313      313              
  Lines       33257    33290      +33     
==========================================
  Hits        18755    18755              
- Misses      12275    12308      +33     
  Partials     2227     2227              
Flag Coverage Δ
tiup 15.90% <0.00%> (-0.03%) ⬇️
unittest 22.71% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/manager/display.go 49.42% <0.00%> (-0.50%) ⬇️
pkg/cluster/spec/tiflash.go 67.55% <0.00%> (-2.96%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hehechen hehechen marked this pull request as ready for review March 9, 2023 09:10
@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Mar 9, 2023
Signed-off-by: hehechen <awd123456sss@gmail.com>
Copy link
Contributor

@AstroProfundis AstroProfundis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to test if -R/--role argument is working with the new patch.

Signed-off-by: hehechen <awd123456sss@gmail.com>
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 15, 2023
@hehechen hehechen requested review from AstroProfundis and removed request for srstack March 15, 2023 02:38
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 15, 2023
@AstroProfundis AstroProfundis added this to the 1.12.0 milestone Mar 15, 2023
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: abbb58d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 15, 2023
@ti-chi-bot ti-chi-bot merged commit 95d4a21 into pingcap:master Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants