-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
display disaggregated mode #2133
Conversation
Signed-off-by: hehechen <awd123456sss@gmail.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #2133 +/- ##
==========================================
- Coverage 56.39% 56.34% -0.06%
==========================================
Files 313 313
Lines 33257 33290 +33
==========================================
Hits 18755 18755
- Misses 12275 12308 +33
Partials 2227 2227
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to test if -R/--role
argument is working with the new patch.
Signed-off-by: hehechen <awd123456sss@gmail.com>
/merge |
This pull request has been accepted and is ready to merge. Commit hash: abbb58d
|
What problem does this PR solve?
What is changed and how it works?
#2135
When the label of TiFlash contains engine-role:write, it means that This TiFlash is a tiflash_write node. So tiflash_write should be displayed in tiup cluster display. But we don't support -R
tiflash_write
ortiflash_compute
now, so just displaytiflash (write)
ortiflash (compute)
.Check List
Tests
Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code
Code changes
Side effects
Related changes
Release notes: