Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiup: mirror clone support specify latest version of a component #1835

Merged
merged 13 commits into from
Apr 13, 2022

Conversation

srstack
Copy link
Collaborator

@srstack srstack commented Apr 9, 2022

What problem does this PR solve?

close #1822

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@srstack srstack self-assigned this Apr 9, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 9, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 9, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 9, 2022

Codecov Report

Merging #1835 (83527d7) into master (542d9f2) will decrease coverage by 7.56%.
The diff coverage is 0.00%.

❗ Current head 83527d7 differs from pull request most recent head 1662ab6. Consider uploading reports for the commit 1662ab6 to get more accurate results

@@            Coverage Diff             @@
##           master    #1835      +/-   ##
==========================================
- Coverage   52.99%   45.43%   -7.56%     
==========================================
  Files         303      302       -1     
  Lines       34678    34687       +9     
==========================================
- Hits        18375    15758    -2617     
- Misses      14151    16843    +2692     
+ Partials     2152     2086      -66     
Flag Coverage Δ
cluster 36.91% <0.00%> (-4.34%) ⬇️
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/repository/clone_mirror.go 0.00% <0.00%> (ø)
pkg/repository/v1manifest/types.go 55.06% <0.00%> (-27.84%) ⬇️
components/dm/ansible/worker.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/cluster/task/update_meta.go 0.00% <0.00%> (-87.10%) ⬇️
pkg/meta/err.go 0.00% <0.00%> (-76.19%) ⬇️
pkg/cluster/api/error.go 0.00% <0.00%> (-75.00%) ⬇️
pkg/crypto/rand/passwd.go 0.00% <0.00%> (-75.00%) ⬇️
pkg/telemetry/node_info.go 0.00% <0.00%> (-70.73%) ⬇️
pkg/utils/error.go 0.00% <0.00%> (-64.29%) ⬇️
components/dm/ansible/import.go 0.00% <0.00%> (-61.63%) ⬇️
... and 73 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 542d9f2...1662ab6. Read the comment docs.

@srstack srstack added this to the v1.10.0 milestone Apr 11, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 13, 2022
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ebd7441

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 13, 2022
@ti-chi-bot ti-chi-bot merged commit 58f86e8 into pingcap:master Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tiup mirror clone support specify latest version of a component
4 participants