fix count error, if advanceNextResponse is empty, we should read next region #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
marsishandsome
force-pushed
the
bugfix/count-error
branch
from
88805ac
to
29457da
Compare
|
/run-all-tests |
zhexuany
reviewed
Jul 1, 2019
tikv-client/src/main/java/com/pingcap/tikv/operation/iterator/DAGIterator.java
Outdated
Show resolved
Hide resolved
|
Good job! I will try to reproduce it. |
|
/run-all-tests |
|
/run-all-tests tikv=v2.1.9 tidb=v2.1.9 pd=v2.1.9 |
zhexuany
reviewed
Jul 1, 2019
tikv-client/src/main/java/com/pingcap/tikv/operation/iterator/DAGIterator.java
Outdated
Show resolved
Hide resolved
|
/run-all-tests tikv=v2.1.9 tidb=v2.1.9 pd=v2.1.9 |
|
/run-all-tests tikv=v2.1.9 tidb=v2.1.9 pd=v2.1.9 |
|
/run-all-tests tikv=v2.1.9 tidb=v2.1.9 pd=v2.1.9 |
marsishandsome
changed the title
marsishandsome
added a commit
to marsishandsome/tispark
that referenced
this pull request
Jul 1, 2019
marsishandsome
added a commit
that referenced
this pull request
Jul 1, 2019
marsishandsome
added a commit
to marsishandsome/tispark
that referenced
this pull request
Jul 4, 2019
wfxxh
pushed a commit
to wanfangdata/tispark
that referenced
this pull request
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closing #877
In DATIterator, if advanceNextResponse is empty, we should read next region instead of just return false.