-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix partition table index scan #735
Merged
zhexuany
merged 15 commits into
pingcap:master
from
zhexuany:fix_partition_table_index_scan
May 21, 2019
Merged
fix partition table index scan #735
zhexuany
merged 15 commits into
pingcap:master
from
zhexuany:fix_partition_table_index_scan
May 21, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birdstorm
reviewed
May 17, 2019
tikv-client/src/main/java/com/pingcap/tikv/util/RangeSplitter.java
Outdated
Show resolved
Hide resolved
zhexuany
force-pushed
the
fix_partition_table_index_scan
branch
from
May 20, 2019 04:38
550de14
to
37a96ab
Compare
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggest to add test: read from partition table with 1000 partitions
tikv-client/src/main/java/com/pingcap/tikv/region/TiRegion.java
Outdated
Show resolved
Hide resolved
Maybe file this "suggest to add test: read from partition table with 1000 partitions" in another PR. @marsishandsome |
marsishandsome
approved these changes
May 21, 2019
birdstorm
pushed a commit
that referenced
this pull request
Jun 4, 2019
birdstorm
pushed a commit
that referenced
this pull request
Jun 4, 2019
wfxxh
pushed a commit
to wanfangdata/tispark
that referenced
this pull request
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only temp fix, I am investigating is there any better fix.
In addition to the real fix, I also improve the explain info and refactor the way to construct ScanPlan.