Fix tempView may be unresolved when applying timestamp to plan #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birdstorm
commented
Apr 29, 2019
| )(sqlContext) | ||
| // Use SubqueryAlias so that projects and joins can correctly resolve | ||
| // UnresolvedAttributes in JoinConditions, Projects, Filters, etc. | ||
| SubqueryAlias(tableName, LogicalRelation(tiDBRelation)) | ||
| } | ||
|
|
||
| protected def resolveRelations(ts: TiTimestamp): PartialFunction[LogicalPlan, LogicalPlan] = { | ||
| protected def resolveTiDBRelations: PartialFunction[LogicalPlan, LogicalPlan] = { | ||
| case i @ InsertIntoTable(UnresolvedRelation(tableIdentifier), _, _, _, _) |
There was a problem hiding this comment.
move InsertIntoTable up to keep same style as ResolveRelations.apply
birdstorm
commented
Apr 29, 2019
| println(df.queryExecution.analyzed) | ||
| df.queryExecution.analyzed.foreach { checkTimestamp } | ||
| df.explain | ||
| println(df.queryExecution.executedPlan) |
There was a problem hiding this comment.
StartTs will be added after Strategies are applied.
birdstorm
commented
Apr 29, 2019
| @@ -823,6 +823,7 @@ public String toString() { | |||
| sb.append(", Limit: "); | |||
| sb.append("[").append(limit).append("]"); | |||
| } | |||
| sb.append(", startTs: ").append(startTs.getVersion()); | |||
There was a problem hiding this comment.
I added a startTs information in TiDagRequest output. Not really sure if it is useful? @zhexuany
There was a problem hiding this comment.
It is better to print it out.
|
/run-all-tests |
birdstorm
changed the title
|
/run-all-tests profile=spark-2.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.