Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix partition parser bug #651

Merged
merged 1 commit into from
Apr 16, 2019
Merged

Fix partition parser bug #651

merged 1 commit into from
Apr 16, 2019

Conversation

zhexuany
Copy link
Contributor

Zero_Decimal is not considered. When it tries to parse "id < 0", it throws an exception.

@zhexuany zhexuany requested a review from birdstorm April 15, 2019 09:01
@birdstorm
Copy link
Contributor

lgtm

@zhexuany
Copy link
Contributor Author

/run-all-tests

marsishandsome
marsishandsome approved these changes Apr 16, 2019
View reviewed changes
Copy link
Collaborator

@marsishandsome marsishandsome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhexuany zhexuany merged commit 4d55bcd into pingcap:master Apr 16, 2019
@zhexuany zhexuany deleted the fix_partition_parser_bug branch April 16, 2019 04:45
wfxxh pushed a commit to wanfangdata/tispark that referenced this pull request Jun 30, 2023
@zhexuany
Fix partition parser can't parser numerical value 0 (pingcap#651)
3f5da86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsishandsome marsishandsome marsishandsome approved these changes

@birdstorm birdstorm Awaiting requested review from birdstorm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhexuany @birdstorm @marsishandsome