Allow TiSpark retrieve row id #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
|
/run-all-tests tikv=release-2.0 tidb=release-2.0 pd=release-2.0 |
|
/run-all-tests tikv=release-2.0 tidb=release-2.0 pd=release-2.0 |
ilovesoup
changed the title
birdstorm
reviewed
Jul 3, 2018
| val tiRelation = new TiDBRelation( | ||
| tiSession, | ||
| new TiTableReference(dbName, tableName), | ||
| meta | ||
| )(sqlContext) | ||
| val df = sqlContext.baseRelationToDataFrame(tiRelation) | ||
| df |
| for (TiColumnInfo col : getColumns()) { | ||
| DataType type = col.getType(); | ||
| InternalTypeHolder typeHolder = type.toTypeHolder(); | ||
| typeHolder.setFlag(type.getFlag() & (~DataType.PriKeyFlag)); |
There was a problem hiding this comment.
i think we should wrap this into a public function, and set PriKeyFlag protected.
| @@ -63,7 +63,7 @@ | |||
| protected final MySQLType tp; | |||
| // Not Encode/Decode flag, this is used to strict mysql type | |||
| // such as not null, timestamp | |||
| protected final int flag; | |||
| protected int flag; | |||
Codecov Report
@@ Coverage Diff @@
## master #367 +/- ##
=========================================
Coverage ? 55.14%
=========================================
Files ? 127
Lines ? 5821
Branches ? 867
=========================================
Hits ? 3210
Misses ? 2316
Partials ? 295
Continue to review full report at Codecov.
|
birdstorm
pushed a commit
that referenced
this pull request
Aug 24, 2018
birdstorm
pushed a commit
that referenced
this pull request
Aug 24, 2018
wfxxh
pushed a commit
to wanfangdata/tispark
that referenced
this pull request
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For implicit primary key, allow TiSpark to retrieve row_id. It's controlled by switch and if turned on, user will be able to see this column and retrieve it.
This change is