Support service safe point (#2634) #2645
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #2634
What problem does this PR solve?
TiSpark does not have a mechanism to check GC. So, you may get the wrong data if your transaction's start_ts behind safe_point
What is changed and how it works?
This PR introduced the service safe point in TiSpark. TiKV will use the min service safe point among all service (including TiDB).
TiSpark will generate a new serviceId for every spark session. Every spark session will register the min start_ts as its' service safe point to PD. Thus, the safe point will not exceed the min start_ts among all spark applications.
Test
It is hard to write IT. Here are the results I test locally.