Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Probe tiflash #2640

Merged
merged 6 commits into from
Mar 13, 2023
Merged

Probe tiflash #2640

merged 6 commits into from
Mar 13, 2023

Conversation

shiyuhang0
Copy link
Member

@shiyuhang0 shiyuhang0 commented Mar 7, 2023

What problem does this PR solve?

#2619

What is changed and how it works?

Check List

Manual test (add detailed scripts or steps below)

start 2 tiflash

tiup playground v6.5.0 --tiflash 2

create a table named test.t

set 2 tiflash replicas for test.t

ALTER TABLE t SET TIFLASH REPLICA 2;

suspend tiflash

kill -stop 4594
kill -stop 4595

read from tiflash

spark.conf
            .set(TiConfigConst.ISOLATION_READ_ENGINES, TiConfigConst.TIFLASH_STORAGE_ENGINE)
spark.sql("select * from tidb_catalog.test.t").show()

TiSpark will retry with the following log

image

recovery tiflash, tispark success

kill -cont 4594

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 7, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • xuanyu66
  • zhangyangyu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@shiyuhang0 shiyuhang0 changed the title probe tiflash Probe tiflash Mar 7, 2023
@shiyuhang0
Copy link
Member Author

/run-all-tests

1 similar comment
@shiyuhang0
Copy link
Member Author

/run-all-tests

@shiyuhang0
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b870470

@ti-chi-bot ti-chi-bot merged commit 30cab9b into pingcap:master Mar 13, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-3.2: #2648.

ti-chi-bot added a commit that referenced this pull request Mar 14, 2023
wfxxh pushed a commit to wanfangdata/tispark that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants