*: fix newtidb encoder #92
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: xhe xw897002528@gmail.com
What problem does this PR solve?
Issue Number: ref #8,
pingcap/log
sectionProblem Summary: I made some mistakes when porting the encoder of
pingcap/log
. This PR should hopefully fix these issues.What is changed and how it works:
pingcap/log
. The requirements are: first, double quotes if needed; second, one message one line, no wrapping.AppendReflected
andAddString
, it is missed in my previous PR.AppendByteString
will encode to hex automatically. This does not violate the RFC. It actually makes more sense. In tikv,[]byte
are mostlykeys
, which will be encoded into a human readable format. But that is not true in go or other components. Just convert all[]byte
to hex. If you need custom encoding, usezap.Stringer
.encodeError
. This workaround is already fixed by *: new tls configuration for operator #80logger.With
... etc, commented the reason for changes.Check List
Tests
Notable changes
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.