Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manager: add logger manager #88

Merged
merged 5 commits into from
Sep 21, 2022
Merged

manager: add logger manager #88

merged 5 commits into from
Sep 21, 2022

Conversation

djshow832
Copy link
Collaborator

What problem does this PR solve?

Issue Number: ref #8

Problem Summary:
The logger configuration cannot be updated online now.

What is changed and how it works:
Add a LoggerManager. It watches the configuration modification and then applies the latest configuration.
The encoder cannot be updated online now. It's not easy to implement it and it doesn't deserve the effort.

This PR doesn't actually use LoggerManager. I'll do it in the next PR.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change (Don't forget to add the declarative for API)
  • Has weirctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

pkg/manager/logger/manager_test.go Show resolved Hide resolved
@djshow832 djshow832 merged commit 31a5604 into pingcap:main Sep 21, 2022
@djshow832 djshow832 deleted the log_conf branch September 21, 2022 03:44
xhebox pushed a commit to xhebox/TiProxy that referenced this pull request Sep 21, 2022
xhebox pushed a commit to xhebox/TiProxy that referenced this pull request Mar 7, 2023
xhebox pushed a commit to xhebox/TiProxy that referenced this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants