Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: apply some lint #87

Merged
merged 4 commits into from
Sep 19, 2022
Merged

*: apply some lint #87

merged 4 commits into from
Sep 19, 2022

Conversation

xhebox
Copy link
Collaborator

@xhebox xhebox commented Sep 17, 2022

Signed-off-by: xhe xw897002528@gmail.com

What problem does this PR solve?

Issue Number: close None

Problem Summary: As title. One notable thing: struct rearrange may improve GC performance.

What is changed and how it works:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change (Don't forget to add the declarative for API)
  • Has weirctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
Copy link
Collaborator

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you know that struct rearrangement can improve GC performance? Is there any tool to rearrange it?

go.mod Outdated Show resolved Hide resolved
@xhebox
Copy link
Collaborator Author

xhebox commented Sep 18, 2022

How do you know that struct rearrangement can improve GC performance? Is there any tool to rearrange it?

These are optimizations from gopls. More accurately, it is just possible to improve but not necessary. Check 1pkg/gopium#24 (comment).

Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox xhebox force-pushed the lint_1 branch 10 times, most recently from d6efffd to bed9c70 Compare September 18, 2022 07:45
Signed-off-by: xhe <xw897002528@gmail.com>
@djshow832 djshow832 merged commit ea3cd6f into pingcap:main Sep 19, 2022
@xhebox xhebox deleted the lint_1 branch September 19, 2022 02:39
xhebox added a commit to xhebox/TiProxy that referenced this pull request Mar 7, 2023
xhebox added a commit to xhebox/TiProxy that referenced this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants