Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

design: add reading metrics to the design of multi-factor-balance #640

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

djshow832
Copy link
Collaborator

What problem does this PR solve?

Issue Number: ref #465

Problem Summary:
Now TiProxy reads from backends when Prometheus is unavailable.

What is changed and how it works:
Update the design of multi-factor-balance

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot requested review from bb7133 and xhebox August 15, 2024 06:59
@ti-chi-bot ti-chi-bot bot added the size/S label Aug 15, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@85f6564). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #640   +/-   ##
=======================================
  Coverage        ?   69.13%           
=======================================
  Files           ?       86           
  Lines           ?     8052           
  Branches        ?        0           
=======================================
  Hits            ?     5567           
  Misses          ?     2088           
  Partials        ?      397           
Flag Coverage Δ
unit 69.13% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

ti-chi-bot bot commented Aug 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Aug 15, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-15 08:09:41.82080339 +0000 UTC m=+428266.524273056: ☑️ agreed by xhebox.

@ti-chi-bot ti-chi-bot bot merged commit cc3a4af into pingcap:main Aug 15, 2024
5 checks passed
@djshow832 djshow832 deleted the balance_rfc branch August 15, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants