Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backend: report errors for unsupported capabilities #51

Merged
merged 1 commit into from
Aug 22, 2022
Merged

backend: report errors for unsupported capabilities #51

merged 1 commit into from
Aug 22, 2022

Conversation

djshow832
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #50

Problem Summary:
Some capabilities are not supported by TiDB now, but in case TiDB supports them one day, the proxy should report errors.

What is changed and how it works:
Report errors for unsupported capabilities in handshake.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change (Don't forget to add the declarative for API)
  • Has weirctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@djshow832 djshow832 requested a review from xhebox August 22, 2022 02:04
@xhebox xhebox merged commit 0de79f7 into pingcap:main Aug 22, 2022
@djshow832 djshow832 deleted the unsupport_cap branch August 22, 2022 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhebox xhebox xhebox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Report errors for unsupported capabilities
2 participants
@djshow832 @xhebox